regmem/wales: time out senedd.wales requests so the scraper doesn't hang - #272
Closed
c-tonneslan wants to merge 1 commit into
Closed
regmem/wales: time out senedd.wales requests so the scraper doesn't hang#272c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Closes mysociety#258. requests.get without a timeout will block indefinitely when the server hangs the TCP connection, which is the periodic failure mode the issue describes. Add a 60s timeout to each call so the scheduled job either succeeds, retries (where the retry loop exists), or fails loud enough that monitoring picks it up. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
Member
|
Dupe of #259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258.
requests.getwithout atimeoutwill block indefinitely when the server hangs the TCP connection, which is the periodic failure mode the issue describes. A 60s timeout per call means the scheduled job either succeeds, retries (where the retry loop exists), or fails loudly enough that monitoring picks it up.