Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
A partial key containing only primary-ignorable characters can sort below its complete value. For the affected utf8mb4_0900_ai_ci prefix range, retain all non-NULL candidates and recheck the full comparison. Update the MyISAM and InnoDB ICP EXPLAIN expectations for the widened scan bounds; query-result rows remain unchanged. Add native regressions for the reported query, equivalent controls, and repeated prepared-statement execution. Preserve observable results across the affected execution paths. Bug report: https://bugs.mysql.com/bug.php?id=120580
29d58f7 to
1f867a1
Compare
|
Thank you for signing the OCA. |
|
/codex |
|
✅ Codex PR Review completed successfully! Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
Reviewed the five changed files at 1f867a14; no high-confidence actionable defects found. The widened lower bound retains non-NULL candidates and marks the range inexact for full predicate filtering. The regression coverage and updated ICP expectations are consistent with that behavior.
Static review only: PR code and tests were not executed.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
ab.chatgpt.com
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
Generated by Codex PR Review for #786 · codex · gpt60 · 98.8 AIC · ⌖ 23.7 AIC · ⊞ 14K
Comment /codex to run again
What does this change do?
A partial key containing only primary-ignorable characters can sort below its complete value. For the affected utf8mb4_0900_ai_ci prefix range, retain all non-NULL candidates and recheck the full comparison. Update the MyISAM and InnoDB ICP EXPLAIN expectations for the widened scan bounds; query-result rows remain unchanged.
Bug report: https://bugs.mysql.com/bug.php?id=120580
Why is it needed?
The affected execution path returns a different query result from the equivalent reference. The change preserves the expression or access-path semantics described above.
How was it tested?
On
trunkata1ef44f1d327b940a763b25eee2c6e146a0ebdb0:The unmodified server fails the new regression with a result mismatch.
The patched server builds successfully.
40 query-result checks pass against separately established expected results, including repeated prepared statements.
Native MTR passes:
main.bug_120580,main.select_count,main.range_all,main.range_icp_mrr,main.innodb_icp,main.myisam_icp.The regression passes with the prepared-statement protocol.
The full database regression suite was not run.
Added MTR coverage under
mysql-test/.Ran
scripts/ci/mtr.shwith its default selection; the explicit native and related tests above were run instead.Ran the full database regression suite.
Contributor checklist
.clang-format.AI assistance
OpenAI Codex assisted with implementation, regression test generation and review. The submitted change was checked with compilation, execution against independently established expected results, a failing unpatched regression, and the MTR tests listed above. No human review is claimed by these automated checks.
Areas touched
mysql-test, sql