Add configurable timeouts for file downloads - #149
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
sylvesterkaczmarek
requested review from
chris-durbin,
flamingbear,
indiejames and
ygliuvt
as code owners
September 10, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
No Jira ID supplied. Fixes #122.
Description
Add optional
Client(download_timeout=...)socket limits for file downloads. Accept a scalar or a(connect, read)pair and apply it to direct, bulk, intermediate-file, and OPeNDAP downloads. DefaultNonepreserves existing behavior; authentication and job polling are unchanged.Document inactivity versus total-duration limits, retry behavior, Future exceptions, and partial-file retry handling. This does not add automatic partial-file cleanup or a total-download deadline.
Local Test Steps
macOS arm64, Python 3.12.11:
pytest --cov=harmony --cov-branch tests: 256 passed, including 17 new timeout cases.Future.result(), and confirm a single-worker executor becomes available again.git diff --checkpassed.No live Earthdata downloads, multi-gigabyte transfers, or Windows/Linux execution were performed.
PR Acceptance Checklist