Add run_config to results - #370
Merged
Merged
Conversation
10 tasks
joverlee521
approved these changes
Jul 20, 2026
joverlee521
left a comment
joverlee521
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making the changes here @DOH-HLK0303! Other than a small formatting issue flagged by this repo's linter, changes looks good to me.
Co-authored-by: Jover Lee <joverlee521@gmail.com>
Contributor
Author
|
Thanks! I thought I installed pre-commit locally but I guess not. I will install now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds the existing write_config function to config.smk to generate the run_config.yaml output in results (similar to mumps build: https://github.com/nextstrain/mumps/blob/main/phylogenetic/rules/config.smk).
Requesting this addition to make it easier to check how parameters are parsed from custom builds.
Checklist
Tested primary build and WA state build. I think the run_config looks as expected for both.