Rename sample to id in samplesheets - #2162
Merged
Merged
Conversation
mashehu
approved these changes
Jul 22, 2026
mashehu
left a comment
mashehu
left a comment
Contributor
There was a problem hiding this comment.
this is a breaking change. I would recommen
mberacochea
approved these changes
Jul 22, 2026
mberacochea
left a comment
mberacochea
left a comment
There was a problem hiding this comment.
Thanks Kate. This will break things in the seqsubmit pipeline until nf-core/seqsubmit#88 is merged into main/dev
Contributor
|
sorry, forgot to delete the comment (was thinking seqsubmit was already released), that's why it was just half-finsihed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
sampletoidin samplesheets. Required for nf-core/seqsubmit#88