Skip to content

fix: whitespace trimming delimiter error - #43

Merged
qvalentin merged 12 commits into
ngalaiko:masterfrom
qvalentin:fix/opening-delimiter-needs-whitespace
Dec 7, 2025
Merged

qvalentin merged 12 commits into
ngalaiko:masterfrom
qvalentin:fix/opening-delimiter-needs-whitespace

Conversation

@qvalentin

@qvalentin qvalentin commented Nov 14, 2025 •

Copy link
Copy Markdown
Collaborator

requires #44

@qvalentin qvalentin changed the title test: add failing test for whitespace trimming delimiter test: whitespace trimming delimiter error Nov 14, 2025
- Modified _left_delimiter to match {{- followed by any whitespace (\s)
- Updated _comment_action to use same pattern for consistency
- Removed prec() to avoid tokenizer consuming preceding whitespace

The key fix was removing prec(1, ...) which was causing the tokenizer
to include preceding whitespace in token size calculations, breaking
text node parsing between actions.
@qvalentin
qvalentin force-pushed the fix/opening-delimiter-needs-whitespace branch from 1e65fea to 93de9c8 Compare November 15, 2025 15:16
@qvalentin
qvalentin marked this pull request as ready for review November 15, 2025 15:37
@qvalentin
qvalentin requested a review from baptman21 November 15, 2025 15:38
@qvalentin qvalentin changed the title test: whitespace trimming delimiter error fix: whitespace trimming delimiter error Nov 15, 2025
@qvalentin
qvalentin merged commit 226692d into ngalaiko:master Dec 7, 2025
5 checks passed
@qvalentin
qvalentin deleted the fix/opening-delimiter-needs-whitespace branch December 7, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant