Skip to content

FIX: Auto-enable fixed skull-strip seed when random seed is set#319

Open
mnoergaard wants to merge 2 commits into
mainfrom
fix_randomness
Open

FIX: Auto-enable fixed skull-strip seed when random seed is set#319
mnoergaard wants to merge 2 commits into
mainfrom
fix_randomness

Conversation

@mnoergaard

Copy link
Copy Markdown
Collaborator

This PR addresses issue #315, by automatically enabling --skull-strip-fixed-seed whenever --random-seed is explicitly provided, so skull stripping no longer remains an independent source of run-to-run randomness.

This also updates the CLI help text, adds a short usage note about reproducible runs, and includes a parser regression test.

@mnoergaard mnoergaard requested review from effigies and oesteban May 25, 2026 19:02
@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (f25c4e8) to head (a0b1f7e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   84.76%   84.77%   +0.01%     
==========================================
  Files          87       87              
  Lines        8964     8974      +10     
  Branches      961      961              
==========================================
+ Hits         7598     7608      +10     
  Misses       1140     1140              
  Partials      226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant