FIX: Auto-enable fixed skull-strip seed when random seed is set#319
Open
mnoergaard wants to merge 2 commits into
Open
FIX: Auto-enable fixed skull-strip seed when random seed is set#319mnoergaard wants to merge 2 commits into
mnoergaard wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 84.76% 84.77% +0.01%
==========================================
Files 87 87
Lines 8964 8974 +10
Branches 961 961
==========================================
+ Hits 7598 7608 +10
Misses 1140 1140
Partials 226 226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #315, by automatically enabling --skull-strip-fixed-seed whenever --random-seed is explicitly provided, so skull stripping no longer remains an independent source of run-to-run randomness.
This also updates the CLI help text, adds a short usage note about reproducible runs, and includes a parser regression test.