Optimize cryptography for forwarded GET/HEAD/SEARCH requests#4008
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4008 +/- ##
==========================================
- Coverage 27.73% 27.72% -0.01%
==========================================
Files 681 681
Lines 46924 46972 +48
==========================================
+ Hits 13015 13024 +9
- Misses 32667 32705 +38
- Partials 1242 1243 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
carpawell
reviewed
Jun 4, 2026
carpawell
left a comment
carpawell
left a comment
Member
There was a problem hiding this comment.
First commit has "TBD" body
| GetRequestToInfo(*protoobject.GetRequest) (aclsvc.RequestInfo, bool, error) | ||
| RangeRequestToInfo(*protoobject.GetRangeRequest) (aclsvc.RequestInfo, error) | ||
| SearchV2RequestToInfo(*protoobject.SearchV2Request) (aclsvc.RequestInfo, error) | ||
| SearchV2RequestToInfo(*protoobject.SearchV2Request) (aclsvc.RequestInfo, bool, error) |
Member
There was a problem hiding this comment.
imo, desc should be extended then
Contributor
Author
There was a problem hiding this comment.
by desc u mean aclsvc.RequestInfo?
Member
There was a problem hiding this comment.
interface, bool arg always confuse
cthulhu-rider
force-pushed
the
object-get-forward-crypto
branch
from
b586591 to
58574ce
Compare
roman-khimov
reviewed
Jun 9, 2026
cthulhu-rider
force-pushed
the
object-get-forward-crypto
branch
from
58574ce to
67b7b32
Compare
carpawell
approved these changes
Jun 11, 2026
Member
|
BTW, authorship needs to be fixed as well. |
Recursive signatures are always more heavyweight than simple ones. Thus, it's more efficient to create new read requests from container SN than re-sign the original ones. Refs #3978. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
object-get-forward-crypto
branch
from
67b7b32 to
cafcaab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.