EC GET fixes#4013
Draft
cthulhu-rider wants to merge 6 commits into
Draft
Conversation
cthulhu-rider
force-pushed
the
fix-ec-get
branch
2 times, most recently
from
a430971 to
ea460d0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4013 +/- ##
==========================================
- Coverage 27.80% 27.79% -0.02%
==========================================
Files 681 682 +1
Lines 46758 46816 +58
==========================================
+ Hits 13003 13012 +9
- Misses 32517 32567 +50
+ Partials 1238 1237 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Defect of d25f426. Previously, in case of fallback to GET by chunk routines, they weren't synchronized request initialization and blocked to wait their turn to copy payload chunks. This could result in the chunks being streamed out of order. Refs #4012. Signed-off-by: cthulhurider <ctulhurider@gmail.com>
Omission of d25f426. Signed-off-by: cthulhurider <ctulhurider@gmail.com>
Break request handling when request context is done. Also do not log such errors. Signed-off-by: cthulhurider <ctulhurider@gmail.com>
Such cases are normal so do not worth log records. Signed-off-by: cthulhurider <ctulhurider@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4012