Make macro fit for Xcode 27 and align with the other macros - #16
Merged
Merged
Conversation
- Enable InternalImportsByDefault on all targets; Swift 6.4 flags the implicit `import Testing` in the SwiftPM-generated test entry point as ambiguous - Run diagnostics tests through SwiftSyntaxMacrosGenericTestSupport with an Issue.record failure handler; the XCTest-based assertMacroExpansion did not fail Swift Testing tests, so diagnostics tests never caught failures - Throw diagnostics only once instead of also calling context.diagnose, which reported every error twice - Use "@name" in error messages of attached macros - Share testMacros between test files and unify suite names - CI: run on the xcode-27 runner with Xcode 27.0 and actions/checkout@v7 - format.sh: format the repository itself instead of its parent directory - README: add a uniform Requirements section Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import Testingin the SwiftPM-generated test entry point as ambiguousIssue.record failure handler; the XCTest-based assertMacroExpansion did not
fail Swift Testing tests, so diagnostics tests never caught failures
reported every error twice
Test plan
swift build -Xswiftc -warnings-as-errors --enable-experimental-prebuiltswith Xcode 27.0swift test -Xswiftc -warnings-as-errors --enable-experimental-prebuiltswith Xcode 27.0sh .github/format.shleaves no changesxcode-27runner🤖 Generated with Claude Code