Add default zero constructor for QuadPrecision#84
Open
ejeffrey wants to merge 4 commits intonumpy:mainfrom
Open
Add default zero constructor for QuadPrecision#84ejeffrey wants to merge 4 commits intonumpy:mainfrom
ejeffrey wants to merge 4 commits intonumpy:mainfrom
Conversation
Most python numeric types have default constructors, and pandas relies on it when building string representations of data frames
Author
|
Fixes #83 |
Member
|
Looks like you need to declare Pandas as a test dependency. |
Author
|
Good point. I think I added that in the right place now. |
Member
|
It looks like there are still failures on the tests for older CPUs and more obscure architectures. Sorry this is so tricky! I think you might need to use importorskip to skip the test if pandas isn't importable. |
Member
|
btw, you can enable actions on your fork so you don't need to wait on me to hit the approve button over here |
Author
|
It turns out the test dependencies weren't being installed in some of the tests. I fixed that and now it's passing on my repo except for the build docs job which looks like it's missing an access token. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most python numeric types have default constructors, and pandas relies on it when building string representations of data frames