chore(plugin-webhooks): drop the dead sys_webhook_delivery i18n blocks#3492
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
17 tasks
`sys_webhook_delivery` was removed from @objectstack/plugin-webhooks when outbound delivery moved to @objectstack/service-messaging (`sys_http_delivery`, ADR-0018 M3), but its translation blocks lingered in all four generated locale bundles — loaded at runtime yet referenced by nothing. - Removed the `sys_webhook_delivery` node from each *.objects.generated.ts bundle (en/zh-CN/ja-JP/es-ES); WebhooksTranslations now carries only sys_webhook. - Corrected the stale ownership comment on SysWebhook that still named sys_webhook_delivery as a live sibling. The dangling SysWebhookDelivery import in scripts/i18n-extract.config.ts was fixed independently on main by #3489, so it is not part of this change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
xuyushun441-sys
force-pushed
the
claude/hungry-edison-9bcceb
branch
from
July 26, 2026 07:27
4d0f2ed to
524e6ea
Compare
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 3 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sys_webhook_deliverywas removed from@objectstack/plugin-webhookswhen outbound delivery moved to@objectstack/service-messaging(sys_http_delivery, ADR-0018 M3). But its stale i18n translation blocks lingered in all four generated locale bundles — loaded at runtime yet referenced by nothing, since the object no longer exists in this plugin.Changes
en/zh-CN/ja-JP/es-ES*.objects.generated.ts): removed the entiresys_webhook_deliverynode (−111 lines each).WebhooksTranslationsnow carries onlysys_webhook.scripts/i18n-extract.config.ts: dropped the danglingSysWebhookDeliveryimport (it pointed at the deletedsys-webhook-delivery.object.js, which broke the documentedos i18n extractregeneration command) and the objects-array entry. It now extractsSysWebhookonly.src/sys-webhook.object.ts: corrected the stale ownership comment that still namedsys_webhook_deliveryas a live sibling; it now points at theservice-messagingsys_http_deliverymigration.Verification
pnpm turbo build --filter=@objectstack/plugin-webhooks --force→ green (ESM + CJS + DTS, i.e. a realtsctype-check).objectsmap is exactly["sys_webhook"];sys_webhook_deliveryabsent from the compiled output.pnpm test(vitest) → 14/14 pass.sys_webhook_delivery/SysWebhookDeliveryreferences in the plugin'ssrcorscripts.Out of scope (flagged separately)
Two stale doc comments in the
platform-objectspackage (src/integration/index.ts,src/apps/setup.app.ts) still namesys_webhook_deliveryas a plugin-webhooks object — left out to keep this change scoped toplugin-webhooks; being handled in a separate cleanup. Theservice-messaging/http-delivery.object.tsold→new field-mapping note is intentional and untouched.🤖 Generated with Claude Code