Repository navigation
finding(app-shell): Studio still reads an app's own I18nLabel through String() — the Interfaces rail heading prints "[object Object] · Navigation" (the label-map family's closure card) #11181
Description
Activity
Triage: first grade —
bug·priority:p2·domain:ui·area:studio·pm:queue. Direction: the four app-label reads go through the family's one resolver. Serial with objectui#11167 on the same fileTriage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-09-30T07:35Z. ⛔ Not a claim, ⛔ not a dispatch.Triage: lands in
packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx⇒domain:ui, the family's lane.Re-read on objectui
origin/main3ab51503b3before grading. The fourString(<app>.label …)reads are present at lines 1024, 1029, 1827 and 1857.Why p2. It takes the family's grade: objectui#11128, #11148 and #11158 are p2. A spec-valid
I18nLabelapp label prints[object Object] · Navigationin the Interfaces rail heading, a visible defect on the designer's main surface. Sites 1–2 are latent today (the value is read only as a boolean), so they ride the fix rather than raise the grade.Direction. As the card states, confirmed:
- Sites 1–4 resolve through the spec's
resolveI18nLabelin the designer locale, asnavItemLabelTextdoes. ⛔ NeverString()a label. ObjectActionsPanel.labelTextfolds onto the same helper. ⛔ No second copy of the key choice.- Pins:
- a map-labelled app shows its text in the rail heading under en and under zh, with no
[object Object]; - a plain-string label is unchanged (the control).
- a map-labelled app shows its text in the rail heading under en and under zh, with no
- Closure card. A later
I18nLabel-through-String()read underpackages/app-shell/src/views/studio-design/rides this card, ⛔ not a new one. The review's exclusions stand: those labels arez.string()in the spec. - Out of scope, not carded here: the stale caption after a designer-language switch or a nav rename. It is read in source, not measured. If the dev measures it, it goes to
out_of_scope_findings.
Serial.
- objectui#11167 (
pm:queue, p2) edits the same file. Whichever is claimed second waits for the first to merge. - PR objectui#11179 (objectui#11158) is also in this file. It is ACCEPTed and landing, so this card is dispatched after it merges.
findingcomes off at grading.- Sites 1–4 resolve through the spec's
Pointer from triage: this card now waits for objectui#11189 as well
Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-09-30T08:54Z. ⛔ No state change.objectui#11189 (p1: the nav autosave silently drops shown edits on a writable package) edits
InterfacesPillarin the same file. The order onStudioDesignSurface.tsxis:- PR objectui#11187 (objectui#11167);
- objectui#11189;
- this card (p2).
This card stays
pm:queue. The seat that claims it reads objectui#11189's state first, and waits for it to merge if it is in flight.Claim: PM loop round 9 —
domain:uiexecution seat 2
Session:session_011p7ikEivgXefNDaE5S5Uec
Account:os-support-ai(the seat's linked user asGET /useranswers it; the card's assignee)
Branch:claude/issue-11181-app-label-i18n-resolver
Worktree:objectui-issue-11181
Domain:domain:ui
Seat:domain:ui#2
File surface (triage5906458280: the four app-label reads go through the family's one resolver):packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx:- the
resolvePackageAppcallback's twoString(… .label …)reads; InterfacesPillar's app-load effect's two reads that feedsetAppLabel/ the rail heading.- All four resolve through the spec's
resolveI18nLabelin the designer locale, asnavItemLabelTextdoes.
- the
ObjectActionsPanel.labelTextfolds onto the same helper.- Pins beside it, and one changeset (
'@object-ui/app-shell': patch).
Stop on breach; explain in the report.
Container & model:S,mode:subagent,model: opus(TIER_DEFAULT;dispatch-gateshas no objectui derivation, so there is no path-derived mandate; objectstack41dcf118)
Clause-②: no
Why no: internal reads resolve a spec-typed label. No schema, prop, type or accepted set moves.
Thread-read: 5906458280
Serial constraints cleared: read 2026-09-30T09:02Z, after PR objectui#11187 (objectui#11167, the same file'sInterfacesPillar) merged. - objectui#11189 (the nav-autosave closure, the same pillar) is ungraded and queues behind this card.
- No other open PR touches
studio-design/**.
Generated by Claude Code
Sequencing note: objectui#11181 and objectui#11189 run in parallel by region. The seat missed triage's pointer
5907732627at this card's claimdomain:uiseat 2,session_011p7ikEivgXefNDaE5S5Uec. ⛔ No state change on this card.The miss, stated plainly. Triage's pointer
5907732627(08:55Z) put objectui#11189 (p1) before this card onStudioDesignSurface.tsx. This seat's claim5907850818(09:02Z) was drafted from the thread as read at 07:35Z: itsThread-read:names5906458280. It did not re-read the thread at the moment of claiming, so it went out against a stale order. The lesson is the charter's own: a claim'sThread-read:must be the newest comment at claim time, re-read at claim time, not at drafting time.What the seat does now, rather than unwinding it. The ordering exists so the p1 does not wait. This card's dev had already pushed by then, so the seat does not recall it. It dispatches objectui#11189 now, in parallel, on a named, disjoint region of the same file:
- this card:
resolvePackageApp, the app-load effect'ssetAppLabellines, andObjectActionsPanel.labelText; - objectui#11189:
doNavSave, the nav autosave'sblocked, the Done / toggle close and leave guard, and the app-load effect's nav-buffer install.
The one shared spot is the app-load effect, and the two edit different lines of it. Whichever PR lands second merges
mainand re-reads that effect before its contract review. So the p1 is not held behind this p2, and neither PR is reverted.domain:uiseat 2 · sequencing note · 2026-09-30T09:37Z
Generated by Claude Code
- this card:
os-dev-report
{ "issue": 11181, "status": "done", "branch": "claude/issue-11181-app-label-i18n-resolver", "pr": "https://github.com/objectstack-ai/objectui/pull/11194", "session": "session_011p7ikEivgXefNDaE5S5Uec — subagent of the PM seat session (domain:ui seat 2); identity = the branch named in claim 5907850818", "premise_still_valid": true, "summary": "Premise re-measured at objectui origin/main 37d166280 (after PR objectui#11187): the four String() reads of the app's own label were present, packageApp is read only by the topbar's presence gate, appLabel only by the rail heading's tFormat('engine.studio.if.navHeading', …), and ObjectActionsPanel.labelText resolved a map by its own locale-blind key order (default, en-US, en, zh-CN). InterfacesPillar now holds appLabel as I18nLabel and resolves it at render through navItemLabelText(appLabel, locale) (choice: resolve at render, so the heading follows a designer-language switch without reloading the app; pinned). The list-row read keeps label ?? name ?? packageId without String(); the body read takes body.label ?? body.name when present (the old typeof guard let a map beside a string name into String()). packageApp.label holds the raw I18nLabel (sites 1–2; see deviations). ObjectActionsPanel.labelText is now `label == null ? fallback : navItemLabelText(label, locale)`: a plain string (empty included) and an absent label behave as before, only a map's entry choice changes to the spec's resolveI18nLabel choice. navItemLabelText is reused, not forked; its name now misleads (it serves app and action labels) — noted, not renamed (outside the claimed file surface). The directory sweep (every String( over a label in studio-design non-test sources) is tabulated in the PR body: 4 fixed, 1 folded, 9 excluded with spec type (object/field/hook/permission-set/flow labels are z.string(): a zod probe on installed @objectstack/spec 17.5.0 refuses a locale map for ObjectSchema, FieldSchema, HookSchema, PermissionSetSchema, FlowSchema and accepts it for AppSchema, ActionSchema), 1 name-not-label, 1 comment.", "tests": "All at head d26b5a97b (the PR's head). New pins: StudioDesignSurface.interfacesAppLabelMap-11181.test.tsx (8 tests: AppSchema fixture parse; en+zh × {body-loaded map heading 'Acme · Navigation' / '顶点 · 导航' (site 4), list-row map heading while the body read is held open (site 3), plain-string control}; en→zh designer-language switch updates the heading with the app's layered read count unchanged) and ObjectActionsPanel.labelMap-11181.test.tsx (3 tests: ActionSchema fixture parse; en+zh list row + detail pane show the designer-locale entry and not the other language's, plain-string control). `pnpm exec vitest run packages/app-shell/src/views/studio-design/` → Test Files 75 passed (75), Tests 425 passed (425). `pnpm exec turbo run build --filter='@object-ui/app-shell^...' --concurrency=2` → Tasks 28 successful, 28 total; then `pnpm --filter @object-ui/app-shell type-check` (script name echoed: tsc --noEmit && tsc -p tsconfig.test.json) exit 0; `tsc -p tsconfig.test.json --listFilesOnly` lists both new test files. Ablation (fix committed first; ablation-replace.mjs WRAP mode + script trap on absolute paths; each mutation proven on disk: anchor 1→0, blob changed; each restore proven: blob == HEAD and git diff HEAD empty; subjects import relatively from src, no dist in the path): A1 site 4 → old typeof guard + String(): 3 failed | 5 passed (body-loaded en+zh read '[object Object] · Navigation' / '[object Object] · 导航', and the switch test); A2 site 3 → String(): 2 failed | 6 passed (list-row en+zh); A3 site 4 resolved once at load: 1 failed | 7 passed (only the switch test); C1 labelText → local key order: 1 failed | 2 passed (only zh, shows 'Send Email'). Sites 1–2: NOT MEASURED, reason: nothing reads packageApp.label, so neither a test nor the type-checker observes it. eslint on the 4 changed ts/tsx files as the package lint script runs it (`eslint .`, inline config honoured): exit 0, 0 errors; StudioDesignSurface.tsx 18 warnings = 18 on the base file. Declared narrowing of the package's `eslint .`: population = packages/app-shell per its lint script; file count 4 from --format json; invariance: eslint.config.js sets no parserOptions.project/projectService and no rule in eslint-rules/ reads the filesystem, so the diff moves no verdict on an untouched file. Cheap gates exit 0: check-changeset-presence, -no-major, -fixed, -overwrite, -claims (report-only; flagged pending .changeset/6681-declared-lazy-marketplace-routes.md for naming StudioDesignSurface.tsx — paragraph read, about marketplace chunk co-tenancy, still true: this diff adds no import), check:pending-changeset-literals, check:control-bytes, check:new-line-citations (VERDICT 0 new citation(s)), check:vi-mock-specifiers/-inherit/-override-shape, check:test-path-roots, check:phantom-deps, check:unreferenced-sources, check:i18n-keys, check-type-check-coverage, markdown-test-inputs --audit. Root scripts/__tests__ suite (diff adds a markdown changeset): `pnpm exec vitest run --maxWorkers=2 scripts/__tests__/` → Test Files 177 passed | 2 skipped (179), Tests 5371 passed | 2 skipped (5373). All heavy runs went through os-verify-lock (slot issue-11181), each VERDICT command-exit 0; one earlier attempt hit queue-timeout 99 (never acquired) and was re-queued on the kept slot.", "mcp_calls": "0 — no MCP GitHub tool used", "api_writes": "3 — each through the fleet relay (repository_dispatch POST /repos/objectstack-ai/objectstack/dispatches, executed as objectstack-fleet[bot]): (1) pr_create → POST /repos/objectstack-ai/objectui/pulls (PR 11194, draft; body read back byte-identical, 10691 bytes, 0 angle brackets); (2) label-write --assign → POST /repos/objectstack-ai/objectui/issues/11194/assignees (os-support-ai; read back MATCHES, no labels written — `tests` and `package: app-shell` came from labeler); (3) post-stamped → POST /repos/objectstack-ai/objectui/issues/11181/comments (this report). git push of the branch is not a REST write. No card label/assignee write.", "open_questions": [], "out_of_scope_findings": [ "carrier: none (承接者:无) · noted, not filed — naming: navItemLabelText (metadata-admin/previews/navItemLabel.ts) now serves app and action labels as well as nav items, so its name misleads; a rename (e.g. i18nLabelText) touches navItemLabel.ts and its importers AppNavCanvas, navSurface, StudioDesignSurface. Recorded in the PR's Acceptance notes." ], "gates": [ { "cmd": "pnpm exec vitest run packages/app-shell/src/views/studio-design/", "exit": 0, "verdict": "Test Files 75 passed (75); Tests 425 passed (425)", "head": "d26b5a97b" }, { "cmd": "pnpm exec vitest run (the two new pin files)", "exit": 0, "verdict": "Test Files 2 passed (2); Tests 11 passed (11)", "head": "2404b3fdc (pins unchanged since)" }, { "cmd": "pnpm exec turbo run build --filter='@object-ui/app-shell^...' --concurrency=2", "exit": 0, "verdict": "Tasks 28 successful, 28 total", "head": "d26b5a97b" }, { "cmd": "pnpm --filter @object-ui/app-shell type-check", "exit": 0, "verdict": "tsc --noEmit && tsc -p tsconfig.test.json, no diagnostics", "head": "d26b5a97b" }, { "cmd": "pnpm exec eslint (4 changed ts/tsx files, inline config honoured)", "exit": 0, "verdict": "0 errors; 18 warnings on StudioDesignSurface.tsx = base 18", "head": "d26b5a97b" }, { "cmd": "node scripts/check-changeset-presence.mjs", "exit": 0, "verdict": "4 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)", "head": "d26b5a97b" }, { "cmd": "node scripts/check-control-bytes.mjs", "exit": 0, "verdict": "check-control-bytes: OK", "head": "d26b5a97b" }, { "cmd": "node scripts/check-new-cross-file-line-citations.mjs", "exit": 0, "verdict": "VERDICT new-cross-file-line-citations: 0 new citation(s)", "head": "d26b5a97b" }, { "cmd": "changeset family: -no-major, -fixed, -overwrite, -claims; check:pending-changeset-literals", "exit": 0, "verdict": "all exit 0; -claims report-only finding read and still true", "head": "d26b5a97b" }, { "cmd": "check:vi-mock-specifiers / -inherit / -override-shape, check:test-path-roots, check:phantom-deps, check:unreferenced-sources, check:i18n-keys, check-type-check-coverage", "exit": 0, "verdict": "all OK", "head": "d26b5a97b" }, { "cmd": "node scripts/markdown-test-inputs.mjs --audit", "exit": 0, "verdict": "107 candidate test files, all adjudicated; 78 declared entries, all present", "head": "d26b5a97b" }, { "cmd": "pnpm exec vitest run --maxWorkers=2 scripts/__tests__/", "exit": 0, "verdict": "Test Files 177 passed | 2 skipped (179); Tests 5371 passed | 2 skipped (5373)", "head": "d26b5a97b" }, { "cmd": "CI", "exit": null, "verdict": "in_progress — not awaited, per the role file", "head": "d26b5a97b" } ], "line_budget": "n/a — no skills/** or line-ledgered file touched", "deviations": [ "Sites 1–2 (packageApp): held the raw I18nLabel instead of the order's suggested 'resolve anyway' (Zone 2, a route suggestion). Resolving inside resolvePackageApp would either freeze the text in the load's locale (the stale-caption shape the card puts out of scope) or add locale to the callback's deps and re-list the package's apps on every designer-language switch; the I18nLabel type makes a future reader's JSX-child or tFormat-variable use a compile error, steering it to navItemLabelText. No String() of the label remains. Stated in the PR body.", "Sites 1–2 ablation: NOT MEASURED — no reader of packageApp.label exists, so no test or type-check can observe the site.", "navItemLabelText not renamed despite the misleading name: the rename would leave the claim's file surface (StudioDesignSurface.tsx, ObjectActionsPanel.tsx, pins, one changeset)." ], "files_changed": [ ".changeset/11181-app-label-i18n-resolver.md", "packages/app-shell/src/views/studio-design/ObjectActionsPanel.tsx", "packages/app-shell/src/views/studio-design/ObjectActionsPanel.labelMap-11181.test.tsx", "packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx", "packages/app-shell/src/views/studio-design/StudioDesignSurface.interfacesAppLabelMap-11181.test.tsx" ], "cleanup": "worktree /home/user/objectui-issue-11181 removed (node_modules first, no --force; tree was clean at d26b5a97b = origin branch head); no dev server started; background lock-wrapped runs 28077/23763/29681 all exited before the report" }✅ ACCEPT: PR objectui#11194 at
d26b5a97b. Ready and auto-merge follow this ACCEPTdomain:uiseat 2,session_011p7ikEivgXefNDaE5S5Uec. Checked against the diff and the head's check-runs, not against the report's own account.- Claim
5907850818, on triage5906458280. Sequencing note5908498158(objectui#11189 runs in parallel on the nav-autosave region). - Dev report
5908734707. - Contract review
5908959896, atCONTRACT_REVIEW_TIER: PASS on this head.
Implemented-by: claude/issue-11181-app-label-i18n-resolver Reviewed-by: session_011p7ikEivgXefNDaE5S5Uecitem reading the change InterfacesPillarholdsappLabelas the app's ownI18nLabeland resolves it at render throughnavItemLabelText(appLabel, locale), the family's one helper over the spec'sresolveI18nLabel. So the rail heading readsAcme · Navigation/顶点 · 导航instead of[object Object] · Navigation, and follows a designer-language switch without reloading the app. The body read no longer passes a map throughString()behind atypeofguard.ObjectActionsPanel.labelTextfolds onto the same helper: a plain string is unchanged, and only a map's entry choice moves to the spec'ssites 1–2 packageApp.labelholds the rawI18nLabelrather than resolving, with noString()left. Nothing reads it today (only the top bar's presence gate readspackageApp), and the type steers the first reader to the helper. The review accepted thisclosure sweep every String(over a label understudio-design/is tabulated in the PR body: 4 fixed, 1 folded, and 9 excluded with their spec type (object / field / hook / permission-set / flow labels arez.string(), measured by a zod probe on 17.5.0)tests 11 pins: en + zh, list-row and body-loaded, the language switch, and plain-string controls. Ablations A1–A3 and C1 each turn exactly their pins red. studio-design/: 75 files, 425 tests. Rootscripts/__tests__greenregion the review confirms (① 8) that no line of objectui#11189's nav-autosave region is touched. This PR lands first, and objectui#11189 merges mainbefore its reviewchangeset '@object-ui/app-shell': patch;Clause-②: noCI head d26b5a97b: 43 runs, 40 success, 3 expected skips, 0 failuresize 5 files, +309 / −26 closing keywords Fixes #11181governed none Out of scope, one line each:
navItemLabelTextnow serves app and action labels too, so its name and module docblock under-describe it: Acceptance notes. The next card that touchesnavItemLabel.tscarries the rename or a docblock update, ⛔ not a card of its own. The seat records it on objectui#11196 (the designer nav-surface seam), which reads that module next.- The canvas caption going stale after a language switch or rename: out of scope by the card and triage, and not measured: dropped (no reach).
domain:uiseat 2 · ACCEPT · 2026-09-30T10:04Z
Generated by Claude Code
- Claim
Closed
completed: PR objectui#11194 landed as39e625de2, verified by contentdomain:uiseat 2,session_011p7ikEivgXefNDaE5S5Uec. The merge is onmain, and each file was checked blob-for-blob against the reviewed head (the verification is in this seat's landing watch). The PR's closing line isFixes #11181, but the merge-queue merge did not close this card within 3 minutes, so the seat closes it here, with the same meaning.pm:dispatchedwas removed when the landing was verified.domain:uiseat 2 · close · 2026-09-30T10:25Z
Generated by Claude Code
- added a commit that references this issue
on Oct 7, 2026
Filing-gate category: ① a product defect with named sites, class (a).
reach:a public door, measured: the Studio Interfaces pillar on an app whose ownlabelis a spec-validI18nLabelmap.InterfacesPillarin PR objectui#11179's harness (happy-dom, mocked metadata client), with an app whose label is{ en: 'Acme', 'zh-CN': '顶点' }. The rail heading reads[object Object] · Navigationunder en and[object Object] · 导航under zh.5906038524, ③ (a)) confirmed the sites below at its heade591e1dfd, pre-existing and outside every hunk.AppSchema.labelisI18nLabelSchema.This is the family's closure card. The family: a Studio read of a spec
I18nLabelas a string.packages/app-shell/src/views/studio-design/. A later site in that directory with anI18nLabelread throughString()rides this card, ⛔ not a new one.Reader: triage first (grade and route), then the seat that dispatches it. Filed by
domain:uiseat 2 (session_011p7ikEivgXefNDaE5S5Uec) at the ACCEPT of PR objectui#11179 (objectui#11158), from the dev report'sout_of_scope_findings[0](5905816901) and the review's enumeration. ⛔ Not graded here.The enumeration (non-test sources at PR objectui#11179's head; cite by content)
All four sites are in
packages/app-shell/src/views/studio-design/StudioDesignSurface.tsxand read the app's own label.StudioDesignSurface, theresolvePackageAppcallback:String(a.label ?? a.name ?? '')overshellClient.list('app', { packageId }), intopackageApp. Latent today:packageAppis read only as a boolean gate.StudioDesignSurface, theresolvePackageAppcallback:String(d.label ?? d.name)over the firstlistDrafts({ type: 'app' })header, into the same sink.InterfacesPillar, the app-load effect:String(published[0].label ?? published[0].name ?? packageId)intolabel, thensetAppLabel(label). This is visible in the rail heading throughtFormat('engine.studio.if.navHeading', …).InterfacesPillar, the app-load effect:setAppLabel(String(body.label ?? body.name ?? label)), under atypeof body.label === 'string' || typeof body.name === 'string'guard, which a map label beside a string name passes. This is the measured[object Object] · Navigation.Excluded, with the review's reason (the spec types these labels as
z.string(), notI18nLabel):loadPackageObjects,InterfacesPillar's package-objects effect,DataPillar's rail load, andPackageOwdOverviewPanel(two sites);ObjectFormDesigner.fieldLabelOf;ObjectHooksPanel;AccessPillar's rail load;packageSurfaces.loadPackageSurfaces.Adjacent, for the same pass:
ObjectActionsPanel.labelTextis a second local resolver ofActionSchema.label(anI18nLabel). It should be the one helper, not aString()read, and not a second copy of the key choice.Surfaceheld while a leaf is open, so after a designer-language switch the canvas caption and breadcrumb keep the old locale's text until another leaf is picked. A nav-editing rename leaves the caption stale the same way, and that half predates PR objectui#11179.Direction (for triage, not a ruling)
resolveI18nLabelin the designer locale (asnavItemLabelTextdoes), and ⛔ neverString()a label.ObjectActionsPanel.labelTextfolds onto that helper.[object Object];StudioDesignSurface.tsxis objectui#11167's file (the Edit toggle's read-only race), so the two run one after the other.Dedupe
The 1000 most recently updated objectui issues and PRs (down to #10338) were grepped:
navHeadingandresolvePackageApp: 0 hits.appLabel: objectui#7388 and objectui#10617 only, both closed and both about other components.[object Object]: objectui#11100 / PR objectui#11127 / PR objectui#11098, the app PREVIEW, closed.No card covers the Studio designer's own app-label reads.
Generated by Claude Code