Skip to content

feat(types)!: ObjectGridSchema.defaultFilters and the flat gantt / map filter follow their @objectstack/spec rows by reference (objectui#6152, round 10) - #11993

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-6152-r10-default-filters
Oct 8, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-6152-r10-default-filters

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #6152 (round 10). Round 11 (the list VIEW's per-view-type blocks) is still to come, so #6152 remains open.

Clause-②: yes — it widens: the flat ObjectGridSchema.defaultFilters mirror, and through it an object-view's table.defaultFilters, now ACCEPTS the ViewFilterRule array the object-grid row declares (the old z.record(z.string(), z.any()) refused it). It narrows: the record form of defaultFilters is refused on both faces, and the flat ObjectGanttSchema / ObjectMapSchema filter refuse the AST tuple array they took as any[].

What changed

Three flat members now take their @objectstack/spec 17.7.0 row's own member by reference, on the TypeScript interface (packages/types/src/objectql.ts) and on the zod mirror (packages/types/src/zod/objectql.zod.ts):

member was now
ObjectGridSchema.defaultFilters Record (string keys, any values) / z.record(z.string(), z.any()) ObjectGridProps['defaultFilters'] / ObjectGridPropsSchema.shape.defaultFilters
ObjectGanttSchema.filter any[] / z.array(z.any()) ObjectGanttProps['filter'] / ObjectGanttPropsSchema.shape.filter
ObjectMapSchema.filter any[] / z.array(z.any()) ObjectMapProps['filter'] / ObjectMapPropsSchema.shape.filter

Each is the ViewFilterRule array [{ field, operator, value }, ...]. The zod members are the rows' own objects (identity is pinned), so a record is refused with the protocol's own ruleArrayFilterError message, which computes the rule array from the author's keys. defaultFilters keeps its @deprecated tag: the row's own description still says "Prefer filter".

Doors. The flat grid mirror is the source of the object-view table slot, so table.defaultFilters (objectui's own door) moves with it on the tolerant face, the strict face and safeValidateSchema. The authored object-grid node's properties bag is the row itself and already gave these verdicts (pinned as a control). The flat gantt / map mirrors are not authoring arms (objectui#10859): their authored nodes' bags are the rows, which already refused the tuple array, so no authored door moves there.

No reader changed. ObjectGrid already lowers defaultFilters through the same toFilterNode sink as filter (objectui#4082), so the spec's shape was already honoured; this was a declaration gap, not an implementation gap.

Sentences this head would have made false, repaired (each called the key Record typed): the defaultFilters comment in ObjectGrid.tsx's load effect; the toFilterNode docblock in packages/core/src/utils/filter-converter.ts; the mergeFilterNodes comment in packages/plugin-view/src/ObjectView.tsx (outside the claim's listed surface: a one-comment repair, stated here as the round-9 ACCEPT treated its two doc sentences); and the "write this / not this" row in content/docs/plugins/plugin-view.mdx and packages/plugin-view/README.md, which taught defaultFilters as a record of field to value (equality-only).

Measurement first

1. The spec's shape (installed @objectstack/spec 17.7.0, ui/component.zod.ts): the object-grid row's defaultFilters is z.array(ViewFilterRuleSchema, { error: ruleArrayFilterError(...) }).optional(), the same wrapper chain as filter, described "Legacy base-filter fallback, read only when filter is absent ... Prefer filter" (narrowed, not retired, by the row's own note). The gantt and map rows' filter are the same rule-array member. The pin re-reads all three on every run.

2. The reader (H2 holds). Measured through the registered object-grid renderer and a ValueDataSource that applies the $filter it receives: defaultFilters: [{ field: 'status', operator: 'equals', value: 'open' }] sends [['status', 'equals', 'open']] and draws the two open rows of three; the same array written as filter sends the same $filter and draws the same rows. Lit control: a closed rule moves both readings (one row). Controls: no key draws all three and sends no $filter; written both ways, filter wins. New pin: packages/plugin-grid/src/__tests__/ObjectGrid.defaultFiltersRuleArray-6152.test.tsx.

3. Corpus census, before any edit. A TypeScript-AST census over the authored corpus (examples/ with the schema catalog, content/, skills/, docs/, apps/, the root README and every package README; tests and CHANGELOGs excluded): 941 files. Controls: the extractor saw 53 object-grid, 46 object-view, 27 object-gantt and 22 object-map node literals, and 11 filter keys on typed nodes.

looked for authored occurrences
a defaultFilters key on any node (flat, in a bag, or in an object-view table), either shape 0
a filter on an object-gantt / object-map node, flat or in its bag, any shape 0
prose naming defaultFilters 9 lines in 2 documents (plugin-view.mdx, plugin-view README); 2 of them taught the record shape, corrected here

objectstack (read-only): no authored defaultFilters outside tests and the spec package; the spec ships its own migration (object-grid-default-filters-rule-array).

Test fixtures, classified separately. Re-spelled to the rule array because a typed fixture became a tsc error: ObjectGrid.filterContextTokens-10607 (2 cells), ObjectView.tableSlotRelay-10976 (1, now a value distinct from filter's so a swap cannot read as arrival), ObjectMap.schemaAlignment (1), gantt-flat-config-declared-keys (the GOOD value and the _FilterIsDeclared row); object-gallery-filter-9309's source census updated for the two new spellings. Left as written: 18 record-valued cells in 5 untyped runtime tests (gridDefaultFiltersLowering, ObjectGrid.malformedFilter-9050, ObjectView.canonicalTableKeys, ObjectView.filterSources, ObjectView.namedViewContextTokens-10506). They pin the READ, which did not narrow (the objectui#10199 split, as round 8 left its AST fixtures); gridDefaultFiltersLowering's two comments that called the record "the declared shape" now say "declared until this round".

H1 holds for authored nodes (zero) and is falsified in prose: two documentation rows taught the record. H3 holds: the flat gantt / map filter readers are ObjectGantt and ObjectMap (each useResolvedFilter(schema.filter, …) onto $filter), plus ObjectMap's legacy filter.map probe, which reads the value as unknown, warns, and was already outside any[] for a record. ElementDataSourceGate writes a merged AST to filter at runtime, and ListView writes its effective filter onto a gantt node from an unknown-typed value. tsc on all of them stays green; no renderer changed.

Not by reference, stated: the tuple-array refusal is the row's element-level message (expected object, received array at filter.0), which does not name the rule array; only the record refusal carries the conversion. Changing that would mean a local copy of the member, so it is left to the spec.

Tests

On head e2fe94285, under os-verify-lock:

  • pnpm exec vitest run --maxWorkers=2 packages/types/ packages/plugin-grid/ packages/plugin-gantt/ packages/plugin-map/ packages/plugin-view/ packages/core/ apps/console/src/__tests__/registry-inputs-spec-parity.test.ts: Test Files 962 passed | 1 skipped (963), Tests 17511 passed | 141 skipped (17652).
  • pnpm exec vitest run --maxWorkers=2 scripts/__tests__/: Test Files 179 passed | 2 skipped (181), Tests 5452 passed | 2 skipped (5454).
  • The lock held 26m07s for both and the doc gates' build closure (35/35 turbo tasks), on a shared box.
  • The two new pins alone: the @object-ui/types round-10 pin (grid-default-filters-gantt-map-filter-round10-6152.test.ts) 84 tests; the plugin-grid H2 pin 5 tests.

type-check (script name echoed on every row) after turbo run build --filter='@object-ui/console^...' --filter='@object-ui/example-schema-catalog^...' (34/34 tasks): types, core, app-shell, plugin-calendar, plugin-dashboard, plugin-designer, plugin-gantt, plugin-grid, plugin-kanban, plugin-list, plugin-map, plugin-tree, plugin-view, console, example-schema-catalog: every package whose source names ObjectGridSchema, ObjectGanttSchema, ObjectMapSchema or ObjectViewSchema (the consumers, downstream of @object-ui/types). The first sweep was red only on the three typed fixtures above (plugin-grid, plugin-map, plugin-view test configs; every package's src compiled); green after the re-spelling, against a rebuilt types dist.

Gates, all exit 0, on the same head after that build:

  • pnpm check:doc-snippets (784 of 784 blocks judged, 0 failed), check:doc-examples, check:skill-examples, check:doc-types, check:readme-exports
  • check:spec-symbols; check:component-surface-parity (report-only, no row for these members)
  • node scripts/check-changeset-presence.mjs (13 source files of 5 released packages, 1 changeset), node scripts/check-changeset-no-major.mjs, check:changeset-claims, check:pending-changeset-literals
  • check:new-line-citations (0 new), check:control-bytes
  • node scripts/check-governed-queue-guard.mjs --test over the 16 paths: NOT GOVERNED

ESLint over the 13 changed TS files: 0 errors (warnings pre-existing no-explicit-any / react-hooks).

Ablations (one-shot, through ablation-replace.mjs; each mutation proven on disk, each restore to the HEAD blob with an empty git diff HEAD)

Predictions were written before the runs; every observed direction matched.

  • A. defaultFilters mirror back to z.record(z.string(), z.any()).optional(): the round-10 pin goes 27 red / 57 green, exactly the predicted set (member identity; the grid defaultFilters verdict rows for the rule array, the empty array, the record and the empty record; on each of the three doors the rule-array, record and tuple rows and the same four verdict rows; the object-view mirror's slot). Green: the precondition, the gantt / map rows, the grid filter lit control, the door lit controls, the authored-bag control.
  • B. gantt mirror filter back to z.array(z.any()).optional(): 4 red (the gantt / map identity test; the gantt tuple, AST and unknown-operator verdict rows); gantt-flat-config-declared-keys stays green (its refused value is a string).
  • C. a consumer literal in plugin-grid/src/ObjectGrid.tsx, typed ObjectGridSchema, with defaultFilters: { status: 'open' }: plugin-grid tsc red (TS2353, status not in the rule type); control leg with the rule array green. This proves the consumer reads the rebuilt .d.ts.
  • D. the same in plugin-gantt/src/ObjectGantt.tsx with filter: [['status', '=', 'open']]: red (TS2322); control leg green.
  • The first C/D attempt was a no-op: ablation-replace refused it because the replacement re-contained the anchor, ran nothing, and restored. Re-run with an anchor-altering replacement; the numbers above are the second attempt's.

Acceptance notes

  • packages/plugin-list/src/ListView.tsx's buildEffectiveFilter docblock still says table.defaultFilters is "declared Record". Fenced from this round (objectui#11860 is in flight on that file). Carrier: objectui#11860's PR, or the next PR that touches ListView.tsx.
  • ObjectView.tsx's gridSchema memo comment says ObjectGrid "raw-assigns the legacy" defaultFilters slot. That has been false since objectui#4082 (it is lowered through the same sink), not made false here. Carrier: the next PR that touches that memo.
  • The gantt and map Schema API blocks in content/docs/plugins/plugin-gantt.mdx / plugin-map.mdx spell the bag's filter as an array of any. Not false (the row takes an array), only imprecise. Carrier: none.

Implemented by the dispatched os-dev run (mode subagent) in session https://claude.ai/code/session_01DBZ9bntPZ7VKyQNtJeNsgw, claim 6063790756.


Generated by Claude Code

claude added 3 commits October 8, 2026 16:12
…p filter follow their @objectstack/spec rows by reference (objectui#6152, round 10)

ObjectGridSchema.defaultFilters takes the object-grid row's own member,
the ViewFilterRule array (was Record<string, any> / z.record), so the
object-view table slot accepts the rule array and refuses the record.
ObjectGanttSchema.filter and ObjectMapSchema.filter take their rows'
rule array (was any[] / z.array(z.any())). No reader changes: ObjectGrid
lowers defaultFilters through the same toFilterNode sink as filter.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DBZ9bntPZ7VKyQNtJeNsgw
…objectui#6152, round 10)

ObjectGrid.filterContextTokens-10607 and ObjectView.tableSlotRelay-10976
wrote a record defaultFilters, and ObjectMap.schemaAlignment a tuple
filter, on typed nodes; each now writes the rows' ViewFilterRule array.
The defaultFilters JSDoc keeps the "Use filter instead" wording the
console parity exemption quotes.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DBZ9bntPZ7VKyQNtJeNsgw
… (objectui#6152, round 10)

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DBZ9bntPZ7VKyQNtJeNsgw
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 337 chunks) 3311.2 KB 3312.0 KB
Main entry chunk (gzip) 71.4 KB 350 KB
Entry file index-Bf6zF1p5.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 18.33KB 6.73KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 587.07KB 141.28KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 240.39KB 67.09KB
fields (index.js) 268.74KB 68.04KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.50KB 11.82KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.43KB 15.54KB
plugin-charts (index.js) 84.71KB 23.25KB
plugin-chatbot (index.js) 199.63KB 47.46KB
plugin-dashboard (index.js) 144.20KB 38.95KB
plugin-designer (index.js) 231.46KB 48.87KB
plugin-detail (index.js) 248.57KB 65.47KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 177.11KB 45.88KB
plugin-gantt (index.js) 179.17KB 45.07KB
plugin-grid (index.js) 248.22KB 68.84KB
plugin-kanban (index.js) 52.22KB 16.38KB
plugin-list (index.js) 117.72KB 29.41KB
plugin-map (index.js) 27.24KB 9.03KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 39.10KB 11.81KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 91.09KB 22.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: e2fe94285da9739d9ef79bef4dece6402277aeb6
Local-runs: none

PR objectui#11993, round 10 of card objectui#6152 (draft, base main, first line Part of #6152 (round 10), no closing keyword, so the card stays open for round 11). Inputs, and nothing else: the card body and all 67 comments (the round-8 ACCEPT 6060539258 that booked this round and its restatements in 6061003736, 6063350688 and 6063750702; the claim 6063790756; the dev report 6065197618; the standing rulings 5957903936 and 5958245046; the earlier at-tier records on this card for shape), the PR body, its 16-file list, the net diff against main at the merge base 1473757b (16 files, +542 / −47, the same 16 paths as the file list, 3 commits), and the 43 check-runs on this head: 40 success, 3 skipped by design (dependabot, coverage, coverage shard), 0 failure. Gate verdicts are read off those check-runs; nothing was built, run or re-run here, and the shared checkout was read with git show, git grep and git diff only. The dev's local vitest counts, type-check sweeps, census, probes and ablations are read as declared, not as verdicts.

① Derived judgments

Published TypeScript face (@object-ui/types, packages/types/src/objectql.ts):

  1. ObjectGridSchema.defaultFilters: a string-keyed Record of any to SpecObjectGridProps['defaultFilters'], which the new pin reads as ViewFilterRule[] | undefined — RIGHT. This is the item the round-8 ACCEPT booked for round 10 (6060539258, carried in 6063350688 and 6063750702): the object-grid row has declared the member as the same rule array as filter since spec 17.6.0, and the installed spec on this head is 17.7.0 (packages/types/package.json declares ^17.7.0; the lockfile resolves @objectstack/spec@17.7.0). Two effects, both intended: the rule array now type-checks where it was a tsc error, and the record form { status: 'open' } is a tsc error where it type-checked. The @deprecated tag stays, matching the row's own "Prefer filter" (narrowed, not retired). The member is taken by reference through the existing SpecObjectGridProps alias, on the round-8 filter precedent.
  2. The object-view table slot moves with it on the TypeScript face — RIGHT and necessary, not a separate stroke: ObjectViewSchema.table is a partial pick of ObjectGridSchema over ObjectGridSlotKey, and 'defaultFilters' is in that key list (objectql.ts about :2397), so table: { defaultFilters: { status: 'open' } } is refused at compile time and the rule array is accepted. Pinned with a real @ts-expect-error directive on the slot literal and an Equal type pin on the slot member.
  3. ObjectGanttSchema.filter and ObjectMapSchema.filter: any[] to SpecObjectGanttProps['filter'] / SpecObjectMapProps['filter'] (each ViewFilterRule[] | undefined) — RIGHT, the second half of the same booking. Narrowing only: any[] admitted the AST tuple array [['status', '=', 'open']], which the rows refuse. The two new type imports (ObjectGanttProps as SpecObjectGanttProps, ObjectMapProps as SpecObjectMapProps) follow the file's existing aliasing rule, and the alias is needed because ObjectGanttProps is also plugin-gantt's own component props name.
  4. No other exported declaration moved. The diff's remaining objectql.ts lines are the three members' doc comments, each of which states the objectui#10199 split (the read is wider than the authored face) rather than publishing the runtime AST shape — RIGHT, the shape ObjectGridSchema.filter already uses.

Zod accept sets (@object-ui/types/zod, packages/types/src/zod/objectql.zod.ts: the flat mirrors, the tolerant AnyComponentSchema, the strict StrictAnyComponentSchema, safeValidateSchema):

  1. ObjectGridSchema.defaultFilters: z.record(z.string(), z.any()).optional() to stripImportedDefaults(SpecObjectGridPropsSchema).shape.defaultFilters — RIGHT. The mirror WIDENS: the rule array the row declares was refused by the record validator and now parses. It NARROWS: the record is refused at defaultFilters with the row's own ruleArrayFilterError message, which computes the rule array from the author's keys; the tuple array is refused at defaultFilters.0; an unknown operator and a string clause are refused. Identity with the row's member is pinned (toBe, with a control that it is not the row's filter), and verdict equality with the installed row is pinned over eight values with "both verdicts occur" asserted. The spelling is the round-8 filter line's (:632), the inline form check:spec-symbols requires.
  2. The object-view table slot moves on all three doors — RIGHT and necessary: the slot is built from ObjectGridSchema.shape (:1283, BaseSchema.extend(ObjectGridSchema.shape) then .omit(...), the withheld set and .partial()), so table.defaultFilters now accepts the rule array and refuses the record at table.defaultFilters with the protocol's message, and the tuple array at table.defaultFilters.0, on the tolerant face, the strict face and safeValidateSchema. This is objectui's own door and the one authored door this round moves, as the booking said. Pinned per door, with table.filter as the lit control (unchanged since round 8) and the object-view mirror's own slot agreeing.
  3. ObjectGanttSchema.filter and ObjectMapSchema.filter: z.array(z.any()).optional() to the rows' own filter members — RIGHT. Narrows the flat mirrors only (tuple array, AST node, record, unknown operator refused). No authored door moves: since objectui#10859 the authored object-gantt / object-map node's properties bag IS the row, and the parity ledger's own arm descriptions (zod-mirror-parity.test.ts about :5002 and :5013) pair the flat mirror with the TS declaration as "the renderer's post-hoist reading", not with the authored arm. Identity pinned, with a gantt-is-not-map control.
  4. The authored object-grid node's bag is unchanged and gives the same verdicts — RIGHT, pinned as a control on all three doors.
  5. stripImportedDefaults leaves the static type and, for a member without a default, the member object itself unchanged (its docblock: the same object every call; T in, T out), so "by reference" is literal here. The identity pins above are the measurement, green under the Test shards.

Readers (no code moved):

  1. ObjectGrid.tsx (+8 / −7), ObjectView.tsx (+4 / −3) and core/src/utils/filter-converter.ts (+6 / −2) change comments only; each hunk was read. The read site is unchanged: ObjectGrid hands { filter: schema.filter, defaultFilters: schema.defaultFilters } to useResolvedGridFilters and lowers both through the toFilterNode sink (:2040 to :2050), so a rule array in the legacy slot already reached the wire as AST (objectui#4082). RIGHT: a declaration gap, not an implementation gap, exactly the case the claim conditioned a reader change on ("only if the spec shape needs a reader change").
  2. The new plugin-grid pin ObjectGrid.defaultFiltersRuleArray-6152.test.tsx measures H2 through the registered renderer and a ValueDataSource that applies $filter: a defaultFilters rule array sends [['status', 'equals', 'open']] and draws two of three rows; the same array as filter sends the same and draws the same; a closed rule moves both readings (lit control); no key draws all three with no $filter; filter wins when both are written. Fixtures typed ObjectGridSchema with no cast. RIGHT.
  3. The read did not narrow, and the 18 record-valued cells in 5 untyped runtime tests stay as pins of the read — RIGHT, the objectui#10199 split as round 8 treated its AST-fed runtime fixtures; gridDefaultFiltersLowering's two comments now say the record was the declared shape "until this round", which is true.
  4. ObjectView.tsx still composes defaultFilters: viewFilter || authoredFilters.tableDefaults (:2517), where viewFilter is a named view's filter (NamedListView.filter, any[]), assignable to the narrowed slot; Type Check is green. No producer in packages/*/src or apps/ writes a record into defaultFilters: read off git grep at the head, every non-test hit is one of the two read sites above, a comment, or a declaration.

Test fixtures and censuses:

  1. Four typed fixtures re-spelled to the rule array — RIGHT, each a tsc error under the narrowed member: ObjectGrid.filterContextTokens-10607 (two cells now use the file's MINE rule), ObjectView.tableSlotRelay-10976 (one cell, deliberately a lost rule distinct from filter's open so a slot swap cannot read as arrival), ObjectMap.schemaAlignment (one cell), gantt-flat-config-declared-keys (GOOD.filter, and the strict Equal pin _FilterIsDeclared now reads ViewFilterRule[] | undefined; the @ts-expect-error on a string filter keeps biting).
  2. object-gallery-filter-9309's source census: the gantt and map rows now read SpecObjectGanttProps['filter'] / SpecObjectMapProps['filter'] — RIGHT; a text census of the declarations, red otherwise.
  3. The new types pin grid-default-filters-gantt-map-filter-round10-6152.test.ts: a precondition block on the installed protocol (so a spec bump that moves these rows reddens here first), the identity block, the four-member differential, the three-door slot block, and a TypeScript block whose @ts-expect-error directives are real (the package type-checks its tests, so a re-widened member fails on the unused directive) — RIGHT. The parity ledgers (UnmirroredDeclared, KnownDrift, WiderThanDeclared, MirroredUndeclared) are untouched and green under the Test shards: both faces moved together, so no ledger row was owed.

Docs and prose:

  1. content/docs/plugins/plugin-view.mdx and packages/plugin-view/README.md: the "write this / not this" row taught defaultFilters as a record of field to value (equality-only); it now teaches the rule array and states the refusal — RIGHT and required, since the old row is false on this head. These are the only two prose sites naming defaultFilters outside tests (read off git grep over content/, skills/, docs/, examples/ and every README at the head), which agrees with the dev's census. Build Docs, Doc Snippet Type Check, Doc Example Id Check, Skill Example Check and Internal Docs Link Check are green.
  2. The gantt and map registration filter rows (plugin-gantt/src/index.tsx:182, plugin-map/src/index.tsx:119) already describe the rule-array form and say the record is not this key's shape; nothing was owed there, and nothing on the registration side is false on this head.

File surface against the claim 6063790756: objectql.ts and objectql.zod.ts "with their tests" (the two new pins, the 9309 census, the gantt-flat-config pin); ObjectGrid.tsx and filter-converter.ts (comment repairs the claim conditioned on a sentence becoming false, which it did); the two authored documents the census found; one .changeset/6152-*.md. Beyond the literal list: one comment in plugin-view/src/ObjectView.tsx (a sentence this head makes false; the round-9 ACCEPT 6063350688 amended its surface for the same class), and the typed fixtures in plugin-grid, plugin-view and plugin-map tests that the narrowing turned into tsc errors (the round-8 ACCEPT 6060539258 read "with their tests" to cover the consumers' fixtures). Both fences hold: packages/plugin-list/src/ListView.tsx is not in the file list, and the list VIEW's per-view-type blocks (KanbanConfig, CalendarConfig, GalleryConfig, TimelineConfig) are outside every objectql.zod.ts hunk. Governed Surface Queue Guard is green.

② Semver level

  • What the diff publishes: on @object-ui/types, one TypeScript member widened and narrowed (ObjectGridSchema.defaultFilters, and through the slot pick ObjectViewSchema.table.defaultFilters), two TypeScript members narrowed (ObjectGanttSchema.filter, ObjectMapSchema.filter); on the zod side, table.defaultFilters widened (rule array) and narrowed (record, tuple array) on the tolerant face, the strict face and safeValidateSchema, and the two flat gantt / map mirrors narrowed with no authored door. No renderer behaviour moved. @object-ui/core, @object-ui/plugin-grid and @object-ui/plugin-view carry comment-only source changes; @object-ui/plugin-map carries one re-spelled typed test under src/.
  • .changeset/6152-grid-default-filters-gantt-map-filter.md: @object-ui/types minor; core, plugin-grid, plugin-map, plugin-view patch. Headed feat(types)!:, with a "Widened" paragraph (the rule array, the table slot on all three faces), a "Narrowed (breaking)" list naming each refusal, its respelling and the better remedy (filter), and a "What did not move" paragraph (the renderers' reads; the sink still lowering a runtime record or AST). It names the flat gantt / map members as describing the node as the renderers read it, with the authored bag already refusing the tuple array — MATCHES what the diff publishes. The fixed release group prices a stated break as minor (the precedent of every PASSed round on this card; check-changeset-no-major stands and Changeset Bump Policy is green), and the four patch entries are the presence gate's reading of the touched released packages (the round-8 shape), with the body saying exactly what each carries. Changeset Declaration, Changeset Bump Policy, Changeset Fixed Group Check, Changeset Overwrite Report and Changeset Claim Re-read are all success; git grep over .changeset/*.md at the head finds no other pending body naming defaultFilters, ObjectGanttSchema or ObjectMapSchema, so no append-only note was owed.
  • The Clause-②: line reads yes on the claim, yes on the changeset, and Clause-②: yes — it widens: … It narrows: … on one line of the PR body — RIGHT: the diff does widen (the rule array parses and type-checks where it was refused), so yes is the true value, and the two-way effect is written out on all three sites, the shape the round-6 ACCEPT (5958245046) PASSed for a mixed diff. Noted, not flagged: the round-3 amendment (5914873302) spelled a widen-and-narrow diff yes (narrowing); either spelling names this diff, no gate reads the arm, and the three sites agree with each other and with the diff.

③ Boundary flags

Dev-declared deviations (report 6065197618), each answered:

  • (a) Surface beyond the claim's literal list (the ObjectView.tsx comment; the consumer fixtures) — accepted, judged at ① 14 and in the file-surface paragraph; the two fences hold.
  • (b) The tuple-array refusal does not name the rule array (zod's element-level "expected object, received array" at .0); only the record refusal does — accepted. The members are the rows' own objects by reference; overriding the message locally would mean a local copy of the member, the divergence mechanism the seat refused in 5957903936 (option C). The record refusal, the migration an author most needs, carries the computed rule array and is pinned on every door. The upstream prose matter is rightly left to the spec.
  • (c) The PR was opened at 04a07d2a and the head moved to e2fe94285 a minute later (the changeset gaining plugin-map patch) — accepted; this record, the dev's declared runs and the 43 check-runs all name e2fe94285.
  • (d) The corpus census ran as an instrument with its controls and is not committed as a pin, unlike round 9's — accepted. The claim asked for the census and for the documents it finds, not for a pin; the authored count is zero on both shapes, the two prose sites are corrected, and the doc gates type-check documentation examples against the built types on every head. Nothing on this head depends on a committed census.
  • (e) The PR body's Clause-② line carries both effects on one line while the changeset carries a bare yes — judged at ②.
  • (f) The first consumer ablation attempt was a no-op refused by ablation-replace and re-run — accepted; ablations are read as declared, and the pins they exercised are green under the Test shards and Type Check.

open_questions: none declared, none found. Nothing on this head needs a ruling.

Out-of-scope findings (the report's five), each with its carrier:

  • packages/plugin-list/src/ListView.tsx's buildEffectiveFilter docblock still says table.defaultFilters is declared a string-keyed Record — false on this head (read at :677), inside the claim's fence (objectui#11860 is in flight on that file). Carrier: objectui#11860's PR, or the next PR that touches ListView.tsx. Not a FAIL reason: the fence was the claim's own, and the sentence describes a fallback the sink still lowers, so it misleads no author.
  • ObjectView.tsx's gridSchema memo comment says ObjectGrid raw-assigns the legacy slot — false since objectui#4082, not made false here. Carrier: the next PR that touches that memo.
  • plugin-gantt.mdx:148 and plugin-map.mdx:126 spell the bag's filter as an array of any in their Schema API blocks — true of the rule array, so not false, but no longer a restatement of the declaration. Carrier: the next PR that touches either page.
  • The spec rows' tuple-array refusal message — upstream polish, see (b).
  • The verify lock's hold time — a box fact.

Noted, not flagged:

  • main has moved past the merge base (the PR's base sha differs from 1473757b); no commit between the merge base and the checkout's origin/main touches the five source files this diff edits. The queue arbitrates.
  • The dev's type-check sweep reports every consumer of the four narrowed types green against a rebuilt types dist; the Type Check check-run on this head is the verdict this record relies on.

Escalations: none. No maintainer decision is needed for this head to land. Round 11 (the list VIEW's per-view-type blocks) stays booked on the card as 6063350688 wrote it.

Implemented-by: claude/issue-6152-r10-default-filters
Reviewed-by: session_01DBZ9bntPZ7VKyQNtJeNsgw

VERDICT: PASS

Rendered 2026-10-08T17:41Z · a read-only contract review of PR objectui#11993 on the head named above; the newest record naming this head governs, and any push after it voids it.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 8, 2026 17:43
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 8, 2026 17:43
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit b13ea3c Oct 8, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-6152-r10-default-filters branch October 8, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants