Skip to content

fix(plugin-list): translate the synthetic "All records" user-filter tab (objectui#13405) - #13423

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-13405-all-records-tab-label
Oct 23, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-13405-all-records-tab-label

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Closes #13405
Clause-②: no

What changed

A tabs-mode user-filter bar with showAllRecords appends a synthetic trailing tab, { id: '__all__', … }, whose label was the literal English string 'All records', so a zh-CN list showed it beside translated tabs.

  • packages/plugin-list/src/UserFilters.tsx (TabFilters): the label is now read through useSafeTranslate() (the hook DropdownFilters in the same file already uses) as tt('list.userFilters.allRecords', 'All records'). The translated value is read into a string before the allTabs memo, so the memo keys on that string and not on the per-render identity of tt (AGENTS.md [WIP] Enhance every detail of the designer #10). TabFilters is a component, so the hook path needed no workaround.
  • One new key, list.userFilters.allRecords, in all ten packs under packages/i18n/src/locales/: en All records, zh 全部记录, ja すべてのレコード, ko 전체 레코드, de Alle Datensätze, es Todos los registros, fr Tous les enregistrements, pt Todos os registros, ru Все записи, ar جميع السجلات. No other key is touched.
  • The __all__ id and the tab's behaviour (no conditions, reported as _tab: __all__) are unchanged.
  • .changeset/user-filters-all-records-label-13405.md: patch for @object-ui/plugin-list and @object-ui/i18n.

Why a new key rather than the existing list.allRecords: that key's en value is Title Case (All Records). Reusing it would change the English tab label, and the card asks for en to keep reading All records. Its translations match the new key's values in every non-en pack.

Tests

New file packages/plugin-list/src/__tests__/UserFilters.allRecordsLabel-13405.test.tsx:

  • zh: the filter-tab-__all__ tab reads 全部记录, and no All records text is drawn.
  • en: the tab reads All records. With no provider, the inline fallback also reads All records.
  • CONTROL: the authored tabs keep their authored labels in zh and en.
  • CONTROL: clicking the tab still emits [] and { _tab: ['__all__'] }.
  • The controls wait for the catalogue through a separate probe (t('common.more')), not through the tab label, so they do not depend on the fix.

Results at head 2fbb3b2033:

  • pnpm exec vitest run --maxWorkers=2 packages/plugin-list/ packages/i18n/ (under the verify lock): Test Files 243 passed (243), Tests 2945 passed | 13 skipped (2958), VERDICT command-exit 0.
  • all-locales-key-parity + en-zh-key-parity run explicitly: Test Files 2 passed (2), Tests 48 passed (48).
  • pnpm check:i18n-keys, check:i18n-drift (reports "0 en value(s) changed (1 key(s) added, 0 removed)"), check:i18n-dead-keys (the new key is not listed), and check:i18n-designer-parity: all exit 0.
  • turbo run type-check --filter=@object-ui/plugin-list --filter=@object-ui/i18n: Tasks: 15 successful, 15 total, 0 error TS. Both packages ran tsc --noEmit && tsc -p tsconfig.test.json. Dependents were not type-checked.
  • eslint on the touched files: 0 errors. The 30 warnings are existing no-explicit-any warnings, none on the changed lines.
  • node scripts/check-changeset-presence.mjs: ✅, 1 changeset declared. pnpm check:new-line-citations: 0 new citations.

Ablation. The fix was committed first. Then the label was set back to the literal 'All records' (on-disk check: injected=1, allRecordsLabel uses left=0) and the new file was run. Result: Tests 1 failed | 4 passed (5). Only the zh pin went red; the en, no-provider and both control cases stayed green, as expected. The file was restored with git checkout HEAD --: git diff HEAD is empty and the blob hash matches HEAD.

Acceptance notes

  • Noted, not filed: the same tab strip's allowAddTab affordances are also English literals (title="Remove tab", the Remove tab … aria-label, title="Add filter tab", placeholder="Tab name" and the Add tab button text in TabFilters). They are outside this card's surface and their reach was not measured. Carrier: none.

  • Adds no product-specific widget, dialog, hook or string (see AGENTS.md › Product-neutral renderer)

Session: https://claude.ai/code/session_01WJozybDmRH8z2c5SD7vJkj

🤖 Generated with Claude Code

https://claude.ai/code/session_01WJozybDmRH8z2c5SD7vJkj

…ab (objectui#13405)

A tabs-mode user-filter bar with showAllRecords appended a tab labelled with
the literal English string 'All records', so a zh-CN list showed it beside
translated tabs. TabFilters now reads the label through useSafeTranslate from
the new list.userFilters.allRecords key (inline fallback 'All records'),
added to all ten locale packs. The __all__ id and tab behaviour are unchanged.

Claude-Session: https://claude.ai/code/session_01WJozybDmRH8z2c5SD7vJkj
Co-authored-by: Claude <noreply@anthropic.com>
…nt readiness probe

Claude-Session: https://claude.ai/code/session_01WJozybDmRH8z2c5SD7vJkj
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 77 chunks) 3244.0 KB 3744.1 KB
Main entry chunk (gzip) 82.1 KB 350 KB
Entry file index-CcGjKy9B.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (buildIdentity.js) 0.80KB 0.49KB
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.41KB 7.90KB
app-shell (runtime-config.js) 24.52KB 8.48KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 45.59KB 12.03KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 42.84KB 11.66KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 614.13KB 150.39KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 253.04KB 70.68KB
fields (index.js) 295.17KB 75.63KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.17KB 11.96KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (ServerReadScope.js) 4.03KB 1.82KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.99KB 0.43KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.91KB
plugin-calendar (index.js) 55.41KB 16.19KB
plugin-charts (index.js) 85.95KB 23.65KB
plugin-chatbot (index.js) 237.89KB 56.23KB
plugin-dashboard (index.js) 147.15KB 39.95KB
plugin-designer (index.js) 232.83KB 50.01KB
plugin-detail (index.js) 267.21KB 71.14KB
plugin-editor (index.js) 2.21KB 1.04KB
plugin-form (index.js) 185.46KB 48.48KB
plugin-gantt (index.js) 178.19KB 45.06KB
plugin-grid (index.js) 278.30KB 77.57KB
plugin-kanban (index.js) 64.27KB 19.81KB
plugin-list (index.js) 149.60KB 39.26KB
plugin-map (index.js) 27.11KB 8.99KB
plugin-markdown (index.js) 13.79KB 4.79KB
plugin-report (index.js) 46.42KB 13.06KB
plugin-timeline (index.js) 39.30KB 11.87KB
plugin-tree (index.js) 15.25KB 5.38KB
plugin-view (index.js) 94.26KB 24.27KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 129.13KB 42.23KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.71KB 2.11KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (product-blocks.js) 0.20KB 0.19KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对

ACCEPT — objectui#13405 (p3, S), head 2fbb3b20332b60b1066658ca88d07ec3521ae37d, reviewed 2026-10-23T19:56Z.

Seat: domain:ui#1 · Clause-②: no

项 读数
形态 13 个文件,+175/−2:packages/plugin-list/src/UserFilters.tsx、一个新测试、10 个语言包各加一个键、一个 changeset(@object-ui/plugin-list、@object-ui/i18n patch)。NOT GOVERNED。均在认领申报的文件面内。与当前 main 无冲突(本次读取时 git merge-tree 无冲突)。没有公开导出变形。
改动核对 读了 diff。TabFilters 用同文件 DropdownFilters 已用的 useSafeTranslate() 读 list.userFilters.allRecords,缺省回落 'All records';译文先读成字符串再进 allTabs 的 memo,依赖的是字符串而不是每次渲染都变的函数。__all__ 的 id 和行为不变。新键在 10 个语言包都有正式译文(zh「全部记录」)。
钉测与门禁 新测试 5 项:zh 读「全部记录」且页面没有英文、en 读「All records」、无 i18n provider 时回落英文、对照:作者定义的 tab 中英文标签不变、对照:点这个 tab 仍发出 [] 与 { _tab: ['__all__'] }。反向验证:放回字面量后 zh 一项变红,其余如预期保持绿。dev 本地:plugin-list 与 i18n 共 243 个文件 2945 项通过;全语言和中英键一致性 48 项通过;check:i18n-keys、check:i18n-drift、check:i18n-dead-keys、check:i18n-designer-parity 通过;type-check 15/15;eslint 0 错误;changeset 和 check:new-line-citations 通过。CI 全绿后由席位转 ready、进合并队列。
接受的偏差 已有的 list.allRecords 英文是「All Records」(大写 R),复用会改英文标签,所以新增一个键,接受。
不在本卡内 dev 记下(PR 已写):同一 tab 条在 allowAddTab 时出现的「Remove tab」「Add filter tab」「Tab name」「Add tab」也是硬编码英文,未查产品里在哪出现,未立卡。
落地条款 Closes #13405:合并后关卡。

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 23, 2026 20:02
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 23, 2026 20:02
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit ad74e98 Oct 23, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-13405-all-records-tab-label branch October 23, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants