Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

fix(plugin-calendar): show the lookup display name for a lookup titleField - #13480

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-zcz7ll
Oct 25, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-zcz7ll

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread

Fixes #13471

Clause-②: no
Metadata-protocol: none

What changed

ObjectCalendar resolved the author's calendar.titleField itself (String(record[titleField]) for any truthy value), so a lookup, which arrives expanded as an object, printed the literal [object Object] on every event. The title now goes to getRecordDisplayName(objectSchema, record, { titleField }), which takes the field as its explicit rung (ADR-0079) and already reduces an expanded reference to its display name. Same fix family as objectui#12188 and objectui#8464.

Precedence is unchanged: the explicit titleField wins when it yields a value, otherwise the object-level ladder (nameField, titleFormat, type-aware derivation, Record #id) runs as before. The change is the one function body in packages/plugin-calendar/src/ObjectCalendar.tsx, plus a new test and a changeset.

Acceptance notes

  • Mechanism check: the PM hypothesis held on origin/main (cd70b78). resolveTitle returned String(v) for an object value. No new fallback or alias was added in the renderer; the existing core resolver is the single authority (AGENTS.md #0.1).
  • Pin: packages/plugin-calendar/src/__tests__/ObjectCalendar.lookupTitleField-13471.test.tsx covers an expanded { _id, name } and { id, name } lookup (shows the name), a raw id string (unchanged), and an expanded object with no usable name or a null value (never [object Object], falls through to nameField).
  • Reverse verification (fix committed first, then ObjectCalendar.tsx checked out from the base commit with a restore trap): 2 of 3 tests red on the base source (expanded name, no-usable-name), the raw-id test green on both sides as intended. After restore git diff HEAD was empty and the implementation line was present.
  • Local gates on head 9e316d4, all exit 0: vitest packages/plugin-calendar/ from the repo root (64 files passed, 465 tests passed, 95 skipped); pnpm --filter @object-ui/plugin-calendar run type-check (the test tsconfig lists the new test file) after building the workspace dependency closure; pnpm --filter @object-ui/plugin-calendar run lint (0 errors, warnings pre-existing); node scripts/check-changeset-presence.mjs; pnpm run changeset:check; node scripts/check-changeset-claims.mjs; pnpm run check:new-line-citations (0 new citations).
  • Behaviour note: a numeric 0 or boolean false titleField value used to fall through to the object-level title (falsy); the shared resolver counts it as a value and prints it. Not a real-world title case; noted for completeness.
  • Not measured: a live browser check against the hotsrm audit calendar; CI covers the full suite.

🤖 Generated with Claude Code

…display-name resolver

ObjectCalendar stringified the author's titleField itself, so a lookup
arriving expanded as an object rendered every event as "[object Object]".
Pass titleField to getRecordDisplayName as its explicit rung instead.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XWGTsmqrtrt1Zqh1ioWqsT
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 85 chunks) 3014.5 KB 3496.0 KB
Main entry chunk (gzip) 80.3 KB 350 KB
Entry file index-CG5a1KK1.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (buildIdentity.js) 0.80KB 0.49KB
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.41KB 7.90KB
app-shell (runtime-config.js) 24.52KB 8.48KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 45.59KB 12.03KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 42.84KB 11.66KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 8.84KB 3.61KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 614.94KB 150.52KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 253.04KB 70.68KB
fields (index.js) 295.90KB 75.88KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.17KB 11.96KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (ServerReadScope.js) 4.03KB 1.82KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.99KB 0.43KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.91KB
plugin-calendar (index.js) 55.31KB 16.16KB
plugin-charts (index.js) 88.30KB 24.33KB
plugin-chatbot (core.js) 5.22KB 2.18KB
plugin-chatbot (index.js) 237.93KB 56.26KB
plugin-dashboard (index.js) 147.15KB 39.95KB
plugin-designer (index.js) 232.83KB 50.01KB
plugin-detail (index.js) 267.21KB 71.14KB
plugin-editor (index.js) 2.21KB 1.04KB
plugin-form (index.js) 185.46KB 48.48KB
plugin-gantt (index.js) 178.19KB 45.06KB
plugin-grid (index.js) 278.30KB 77.57KB
plugin-kanban (index.js) 64.27KB 19.81KB
plugin-list (index.js) 149.60KB 39.26KB
plugin-map (index.js) 27.11KB 8.99KB
plugin-markdown (index.js) 13.79KB 4.79KB
plugin-report (index.js) 46.42KB 13.06KB
plugin-timeline (index.js) 39.30KB 11.87KB
plugin-tree (index.js) 15.25KB 5.38KB
plugin-view (index.js) 94.26KB 24.27KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 129.13KB 42.23KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.71KB 2.11KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (product-blocks.js) 0.20KB 0.19KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT · PR #13480 @ 9e316d405b919adce78b9658ec26aaf8b38bd6ba · domain:ui#4 · 2026-10-25T00:48Z

Reviewer of record: session_01XWGTsmqrtrt1Zqh1ioWqsT (seat 4). Implemented-by: claude/project-thread-zcz7ll (in-seat mode:subagent dev). Card objectui#13471, claim 6391403310.

  1. Shape: draft, base main, Fixes #13471 on the first body line; no other open card number sits next to a closing keyword. 3 files (+138 −14): ObjectCalendar.tsx, one new test, one changeset — inside the claimed surface (the test sits in src/__tests__/, still "its tests").
  2. Premise measured: ObjectCalendar.tsx:1016-1022 on cd70b78 returned String(record[titleField]). The fix hands titleField to getRecordDisplayName(objectSchema, record, { titleField }); the seat read packages/core/src/utils/record-title.ts on origin/main — the third parameter's titleField is the explicit rung (recordDisplayValueAt(record, options?.titleField)), so no new helper and no renderer-side fallback. The test pins an expanded { _id, name } / { id, name } (name shown), a raw id (unchanged) and an unusable reference (falls to nameField, never [object Object]); the dev's reverse run shows 2 of 3 red on the base source.
  3. Gates on this head: 33 check-runs success (Lint, Type Check, Test shards 1–16 and the aggregate Test, Build & E2E, Build Docs, Repo Gates, the changeset family, Line Citation Gate, Governed Surface Queue Guard, Bundle Analysis, Test (dist pins), label, Live E2E (informational)); 3 skipped (coverage jobs, dependabot). mergeable_state: clean.
  4. Accepted deviations: a 0 / false titleField value now prints instead of falling through — not a real title case, recorded in the PR's Acceptance notes. The dev's os-dev-report comment on the card is the role file's own requirement.
  5. Out of scope: none filed; Acceptance notes carry nothing that passes the filing gate.
  6. Landing: not governed (no .claude/**, skills/**, AGENTS.md, workflows); 152 changed lines. Changeset: @object-ui/plugin-calendar patch — the seat read its one sentence against the diff and it matches. Landing waits only for the maintainer's word in this seat's project thread (seat and author share one account).

Generated by Claude Code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calendar view shows "[object Object]" for every event when titleField is a lookup field

2 participants