This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
fix(plugin-calendar): show the lookup display name for a lookup titleField - #13480
Merged
Merged
Conversation
…display-name resolver ObjectCalendar stringified the author's titleField itself, so a lookup arriving expanded as an object rendered every event as "[object Object]". Pass titleField to getRecordDisplayName as its explicit rung instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XWGTsmqrtrt1Zqh1ioWqsT
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
Contributor
Author
席位核对 — ACCEPT · PR #13480 @
|
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Fixes #13471
Clause-②: no
Metadata-protocol: none
What changed
ObjectCalendarresolved the author'scalendar.titleFielditself (String(record[titleField])for any truthy value), so a lookup, which arrives expanded as an object, printed the literal[object Object]on every event. The title now goes togetRecordDisplayName(objectSchema, record, { titleField }), which takes the field as its explicit rung (ADR-0079) and already reduces an expanded reference to its display name. Same fix family as objectui#12188 and objectui#8464.Precedence is unchanged: the explicit
titleFieldwins when it yields a value, otherwise the object-level ladder (nameField,titleFormat, type-aware derivation,Record #id) runs as before. The change is the one function body inpackages/plugin-calendar/src/ObjectCalendar.tsx, plus a new test and a changeset.Acceptance notes
origin/main(cd70b78).resolveTitlereturnedString(v)for an object value. No new fallback or alias was added in the renderer; the existing core resolver is the single authority (AGENTS.md #0.1).packages/plugin-calendar/src/__tests__/ObjectCalendar.lookupTitleField-13471.test.tsxcovers an expanded{ _id, name }and{ id, name }lookup (shows the name), a raw id string (unchanged), and an expanded object with no usable name or a null value (never[object Object], falls through tonameField).ObjectCalendar.tsxchecked out from the base commit with a restore trap): 2 of 3 tests red on the base source (expanded name, no-usable-name), the raw-id test green on both sides as intended. After restoregit diff HEADwas empty and the implementation line was present.packages/plugin-calendar/from the repo root (64 files passed, 465 tests passed, 95 skipped);pnpm --filter @object-ui/plugin-calendar run type-check(the test tsconfig lists the new test file) after building the workspace dependency closure;pnpm --filter @object-ui/plugin-calendar run lint(0 errors, warnings pre-existing);node scripts/check-changeset-presence.mjs;pnpm run changeset:check;node scripts/check-changeset-claims.mjs;pnpm run check:new-line-citations(0 new citations).0or booleanfalsetitleField value used to fall through to the object-level title (falsy); the shared resolver counts it as a value and prints it. Not a real-world title case; noted for completeness.🤖 Generated with Claude Code