Skip to content

fix: retry standby imports while PALF recovers #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangyunlai-seekdb wants to merge 1 commit into
base: release/1.4.0
Choose a base branch
from
Open

fix: retry standby imports while PALF recovers #1361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/logservice/palf/palf_handle_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,15 @@ int PalfHandleImpl::submit_imported_group(
if (!palf_env_impl_->check_disk_space_enough()) {
ret = OB_LOG_OUTOF_DISK_SPACE;
} else if (!state_mgr_.can_append()) {
ret = OB_STATE_NOT_MATCH;
PALF_LOG(WARN, "cannot submit imported group", K(ret), KPC(this),
K(buf_len), "state", state_mgr_.get_state());
// Standby log sync is scheduled immediately at startup. PALF can still
// be recovering at that point, before any imported group's continuity
// has been checked. Retry that transient state, while preserving
// OB_STATE_NOT_MATCH for other non-append states and continuity errors.
ret = state_mgr_.is_recovering() ? OB_EAGAIN : OB_STATE_NOT_MATCH;
if (OB_EAGAIN != ret) {
PALF_LOG(WARN, "cannot submit imported group", K(ret), KPC(this),
K(buf_len), "state", state_mgr_.get_state());
}
} else if (OB_FAIL(sw_.submit_imported_group(source_lsn, source_scn, buf, buf_len))) {
if (OB_EAGAIN != ret) {
PALF_LOG(WARN, "submit imported group failed", K(ret), KPC(this), K(buf_len));
Expand Down