Add cpu_info object and deprecate corresponding attributes in device_hw_info - #1630
Conversation
Add new speed attribute. Create cpu_info array dictionary item. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
New object for cpu_info and array cpu_info_list Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Add the cpu_info_list to the device hardware object. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Deprecate cpu_type for model and vendor. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Deprecation note for cpu_speed. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Add cpu_info object and deprecate flat CPU attributes on device_hw_info in favor of cpu_info_list. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Adjust deprecations and descriptions for cpu change. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Add "cores" as a replacement for "cpu_cores". Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Update for cpu changes. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Schema Description ReviewAutomated suggestions for improving description clarity for LLM consumption. These are advisory — not required changes. Looking at this PR update, I can confirm that all previous issues have been addressed: ✅ Fixed: CHANGELOG spacing - The missing space before PR reference has been corrected in the Now reviewing the current state of all changed attributes: New Issues FoundSuggestions
SummaryThe descriptions are generally clear and well-structured, with good cross-references between related attributes. Two minor improvements would enhance LLM comprehension by making the CPU architecture attributes more self-contained and removing dependency on cross-referencing other schema elements for understanding. |
Add PR for change log entries. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Removed object level description Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Remove content that is already defined in dictionary and unnecessary at this level. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Update description to describe the physical cpu package. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
cpu_info object and deprecate corresponding attributes in device_hw_info
Modify descriptions to use the <code> tag. Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Update case on "information". Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Modify spacing for ocsf#1630 Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
|
Thanks for all the comments and review team! All changes are complete 6/9. |
mikeradka
left a comment
There was a problem hiding this comment.
One CHANGELOG issue before approval: the PR appears to have introduced duplicate ### Bugfixes / ### Deprecated headings under [Unreleased], and it duplicates/moves some unrelated #1597/#1603 deprecation entries. Can you move the #1630 deprecation entries into the existing ### Deprecated section and leave the unrelated entries where they are?
Here is the permalink for reference: https://github.com/jasonbreimer/ocsf-schema/blob/d27d9b13ad821ca9c56bcaa0be86fc03e8455807/CHANGELOG.md
Changes by request Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
|
Thanks @mikeradka good catch. I just fixed. |
Signed-off-by: Jason Reimer <jason.reimer@tanium.com>
Related Issue:
#1572
Description of Changes:
The existing flat CPU attributes on
device_hw_infoare brittle — they assume asingle homogeneous processor and can't represent multi-CPU systems or per-CPU detail.
This PR adds a new
cpu_infoobject andcpu_info_listarray, following the samepattern established by
gpu_info_listin v1.8.0.New:
cpu_infoobject (array namecpu_info_list)speed_mhzdictionary attributecoresondevice_hw_info— total core count across all installed CPUsDeprecated on
device_hw_info:cpu_architecture,cpu_architecture_id,cpu_bits→ use equivalents incpu_info_list[*]cpu_speed→ usespeed_mhzincpu_info_list[*]cpu_type→ usemodelandvendor_nameincpu_info_list[*]cpu_cores→ usecoresincpu_info_list[*]Retained:
cpu_count— system-wide aggregate, usecpu_info_listfor per-CPU detailDelete once you have confirmed the following:
Unreleasedsection in the CHANGELOG.md file? > Complete