rohar - Technical Training

[rohar-odoo]

No description provided.

[robodoo]

[Mathilde411]

Pretty good so far !
Runbot is green so good job !
Also would you be able to squash your commits so that you only have one per chapter ?

[Mathilde411]

Suggested change

	estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
	estate_property_access_user,estate.property.user,model_estate_property,base.group_user,1,1,1,1

Comments for each column:
1st column is the XMLid of the access right, it should be <model_name>_access_<concerned_group> (similarly to record rules in https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming)
second column is the name
2nd column is the name of the rule, the one that will be displayed in the ui, should say the model name and the targeted group (there is not really a fixed way, but a common one is with dots, like suggested)
3rd one is the xmlid of the model targeted, you don't need to add the module name in front if the xmlid is from the same module as you, same for 4th column that represents the targetted group

[Mathilde411]

Good job here !
Here are a few things that I'd have done another way :)