Repository navigation
fix(explorer): ISC mermaid mismatch, default detail-view graph depth to 5, alphabetize lists - #533
Merged
mandy-chessell merged 2 commits intoSep 19, 2026
Conversation
…to 5, alphabetize lists
The Information Supply Chain pane's mermaid diagram differed from the same
chain viewed through Collections. Root cause: ISCDetail in type-explorer.html
read mermaid fields from the sidebar's list-row data (/api/isc,
graph_query_depth=1, no implementation graph, per an earlier perf fix) instead
of the full detail fetch (/api/isc/{guid}, depth=10, add_implementation=True).
A stale comment claimed the list row carried the rich data; it no longer does.
Now always prefers the detail fetch, matching how properties/relationships
already behaved.
Generalize the fix per policy: single-element detail views should default to
graph_query_depth=5 unless a documented perf issue says otherwise. Audited
every handler and bumped ~20 detail endpoints (including the generic
CollectionManager.get_collection_by_guid() call backing most of the
Collections/Digital Products/Agreements/Data Design detail panes, which had
no depth override at all) from depth 1-3 or an unset default up to 5. Left
endpoints with documented, live-verified perf reasons for staying shallow
untouched.
Also alphabetize three list endpoints that were missing it, matching the
sort-by-displayName convention used everywhere else: duplicate_review_handler
(pending pairs, consolidated records) and context_events_handler (event list).
Audited MetadataExpert vs SolutionArchitect/ClassificationExplorer usage per
request; no misuse found -- ISC/blueprint/component data already routes
through SolutionArchitect's native by-guid methods, with MetadataExpert
reserved for unrelated raw counts.
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mandy-chessell
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISCDetailintype-explorer.htmlwas reading mermaid fields from the sidebar's list-row data (/api/isc, depth=1, no implementation graph — from an earlier perf fix) instead of the full detail fetch (/api/isc/{guid}, depth=10,add_implementation=True). Now always prefers the detail fetch.CollectionManager.get_collection_by_guid()call backing most Collections/Digital Products/Agreements/Data Design detail panes) tograph_query_depth=5, the new default for single-element detail views per project policy, unless a documented perf issue says otherwise.duplicate_review_handler.py(pending pairs, consolidated records) andcontext_events_handler.py(event list).MetadataExpertvsSolutionArchitect/ClassificationExplorerusage — no misuse found; ISC/blueprint/component data already routes through SolutionArchitect's native by-guid methods.Test plan
.pyfiles passast.parsesyntax checktype-explorer.html's largest inline script passesnode --check/api/isc/{guid}and/api/collections/{guid}now return byte-identical mermaid content for the same ISC🤖 Generated with Claude Code