Repository navigation
Fix product dependencies - #564
Merged
Merged
Conversation
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
dwolfson
self-requested a review
September 26, 2026 19:26
dwolfson
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coco supply chains: record handoffs between chains as peer links, not overlapping members; set the data lake's deployed implementation type
Summary
A review of
product-dependencies.mdfound dependencies tagged with supply chains they don't belong to. Forexample, Hospital Certifications ← Worker Qualifications was tagged with both Workforce Competency and
Clinical Trials, and the Clinical Trials tag was wrong. The dependency file copied its tags faithfully from
the wires in
strategic-supply-chain-analysis.md, so the problem was in how the analysis modelled datapassing from one chain to another.
The analysis handled each crossing by adding the component on the far side as a "(handover)" member of
both chains and tagging the crossing wire with both. So the chains overlapped, no crossing was visible, and
a wire could carry a chain that neither the data nor the business process belonged to. This PR adopts a
simpler convention:
are listed under each chain in a separate Component | Handoff table, and are not added as members.
chains names no chain;
ISC Qualified Namesis optional.Link Information Supply Chain Peersin
strategic-information-supply-chains.md.with no
ISC Qualified Namefor a crossing wire.Registers (Competency Register, Worker Master Register, Product Master Register, ...) legitimately belong to
several chains, so a wire between two shared members can still name two chains. Five wires do.
Changes
1. coco-data-hub/strategic-supply-chain-analysis.mdCocoComboArchiveand none ofthese components is a member of it.
on "locate employee data" and "payroll postings", and Batch Manufacturing on the incoming-material
testing wires.
reach the ledger through the subledger feeds, so they were being posted twice.
(Accounting ledgers ×3, Market Authorisation Register). 111 remain. Each chain now has a handoffs
table that keeps the original rationale text.
to match (123 wires: 10 crossing, 5 naming two chains).
0. data-governance-program/strategic-information-supply-chains.md1. coco-data-hub/strategic-digital-products/product-dependencies.mdlabelled "carrier journey events" and tagged Cold Chain;
carrier"). Without it, the Cold Chain and Dangerous Goods Consignment dependencies split into two
unconnected halves, because the wires between them pass through the external carrier systems, which
have no product.
___separator was fixed. The overviewand per-chain table were updated.
1. coco-data-hub/README.md,strategic-digital-products/README.md1. coco-data-hub/setting-up-the-data-hub.ipynb"deployedImplementationType": "File System Directory", so the asset is created with its deployedimplementation type.
Verification
___delimiters, complete command blocks) pass on all three commandfiles.
dr_egeria --directive validate: no warnings or errors on the analysis (316 commands), thedependencies (124) and the supply chains file (131).
GUID. That removed 44 memberships, retagged 37 wires, detached 3 wires, detached 51 and created 12
dependencies, and created 9 peer links. Egeria and the files now match exactly: 558 wires,
124 dependencies, 31 chain links.
Dr.Egeria fix this depends on
Re-running a file of multi-link
Linkcommands used to duplicate everyDigitalProductDependencyandSolutionLinkingWire. Both are MULTI_LINK, and Dr.Egeria's check for an existing relationship was missing(dependencies) or never matched (wires). This is fixed in pyegeria 6.1.21. Re-running
product-dependencies.mdon 6.1.21 updated all 124 dependencies in place and created none. Load thesefiles with pyegeria ≥ 6.1.21.
Not in this PR
Working-tree changes outside
coco-workbooks/(the platform Dockerfile,tools/, runtime volumes) are notpart of this PR.
🤖 Generated with Claude Code