Test/debug process geometry - #175
Closed
jnettels wants to merge 20 commits into
Closed
Conversation
Renaming back and forth is unnecessary.
This includes a refactor of _remove_useless_forks to allow reusing part of its logic.
In the process, I refactored some of the logic functions to be easier to understund. for example, `_have_unique_values` was True if there are different values. The new name inverts the logic to `_attribute_values_equal` and should be easier to understand. (Also, the separate NaN treatment in `_all_values_equal` was useless, as NaN != any value.)
It allows construction of a "reverse" house connection lines, and was provided in #166 (comment)
There were two problems when inverting "_all_values_equal": First, the logic in _remove_useless_forks was notinverted. This is now more transparent without continue statement. Second, series of all NaN were not merged because NaN != NaN.
This is not needed anymore because simplify() already includes this step: It uses a networkx Graph, which ony allows one edge between two nodes.
Includes .geojson test files
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not meant to be merged, it is purely for investigating failing tests.