Skip to content

Remove hard dependency on Extension:Bootstrap #70

Description

@malberts

Of the Bootstrap skins listed on https://www.mediawiki.org/wiki/Category:Skins_based_on_Bootstrap, only Chameleon depends on the Bootstrap extension. All other skins bundle their own resources. By requiring that extension, the wiki ends up loading all resources twice, and some skins run into JS event issues as mentioned in #93.

For non-Bootstrap skins that still want to use BootstrapComponents, the extension would still be required.

The check for Bootstrap availability should therefore be:

  • if one of the listed skins, excluding Chameleon, is enabled
  • else if Extension:Bootstrap is enabled (the right version, since the extension no longer enforces it, maybe via composer "suggest"?)
  • fail with current error

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions