Store Skip launcher in the VM workspace - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Deleting the VM workspace previously left Skip launcher enabled in macOS preferences. Store the choice in a versioned
launcher-settings.jsonfile in the selected VM workspace, defaulting to off when the file is missing or invalid. Always show the launcher when there is no existing VM disk, including disposable sessions, even if a settings file remains.Ignore the old UserDefaults value, so existing users must enable Skip launcher again. Custom locations and environment overrides select their own setting; release and development apps sharing a workspace share the choice. Choices made before first launch are retained after the storage backend initializes the workspace, keeping empty custom folders usable. Save errors restore the toggle and explain the failure.
Testing
swift test --package-path macos --disable-sandbox --filter 'StartupPreferenceStoreTests|StartMenuStartupTests|GuestBootFixTests': passed, 22 tests across 3 suites (with repository-local Swift/Clang module caches).make test: passed on Apple Silicon macOS, including 408 Swift tests and the guest, contract, shell, and disk-resize suites. The initial sandboxed run failed local socket tests withOperation not permitted; the unrestricted rerun passed.git diff --check: passed.