Repository navigation
Include the release version in DMG filenames - #316
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Name release downloads
TryOmarchy-vX.Y.Z.dmgusing the version stamped into the packaged app. Accept both the matching versioned asset and legacyTryOmarchy.dmgin release checks, and document uploading the legacy name for older clients.Testing
python3 tests/test-app-version.pyon this isolated branch: passed (5 tests).bash -n macos/build-app.shandgit diff --check 82927e9..HEAD: passed.make teston local main with all ten pending commits: passed on macOS 27.0.1, including versioned-asset acceptance and rejection of assets for a different release. The initial sandboxed run failed socket/notification tests; rerunning with the required access passed.