Conversation
Adds search and read operations to the value annotation adapter, with transitive visibility filtering to ensure annotations on private resources are not accessible to unauthorized users. Adds o:resource and o:value to the JSON-LD representation.
Replaces the ad hoc o:resource/o:value properties in the value annotation JSON-LD output with a standards-based oa:hasTarget/rdf:Statement structure that identifies the annotated triple by subject, predicate, and object. Also declares oa:Annotation as a co-type and registers the oa and rdf namespace prefixes in the API context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Value annotations are a special kind of resource: like items, media, and item sets they can be described by RDF values, but unlike those resources they have no independent lifecycle - an annotation derives its meaning entirely from the value it describes. For this reason, direct CRUD operations have always been intentionally blocked. This PR exposes search and read as read-only operations, which have no bearing on that design constraint.
Design notes
This should fix #2468