Conversation
* Starts with advanced search form. * Also corrects missing group roles on fields. * Adds missing `aria-expanded` and `aria-controls`. * Adjust styles to ensure proper touch target sizing and colors reflecting interactive element.
If a button has a different label and still uses the toggle functionality, the expand/collapse aria-label overrides it.
Also takes text indent off of actions. (#2408)
* Also adds `aria-expanded` attr. * TODO: also apply `aria-controls`. (#2408)
Allows modules using the old anchor pattern to continue working until update. (#2408)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the beginning of Omeka S's development, we had established a pattern of using anchors where we actually wanted buttons for js-powered page interactions. This branch corrects most of these patterns to use the
<button>element.