Conversation
4d95e36 to
c2b5d84
Compare
de7f7bd to
27caad0
Compare
e92f5d5 to
4d59a92
Compare
db4362c to
2f63151
Compare
de99525 to
977cfb9
Compare
Assisted-by: Google Gemini 1.5
| set(CONTENTS_DIR "${APP_PATH}/Contents") | ||
|
|
||
| fixup_bundle("${APP_PATH}" "" "/opt/homebrew/lib;/usr/local/lib") | ||
| file(INSTALL "${SDL3_LIBRARY_PATH}" DESTINATION "${CONTENTS_DIR}/Frameworks" RENAME "libSDL3.dylib") |
There was a problem hiding this comment.
file(INSTALL ... RENAME doesn't exist.
https://cmake.org/cmake/help/latest/command/file.html#install
Perhaps use file(COPY_FILE (new in cmake 3.21) or configure_file(<input> <output> COPYONLY) instead? file(INSTALL followed by a rename defeats some of INSTALL's features, anyway.
There was a problem hiding this comment.
I suspect we may run into trouble dlopen'ing SDL3 after using the bare filecopy, as fixup_bundle will not have tracked down the dylib dependencies of SDL3.
If this trouble does not occur, the manual file copy is good enough to stay-- considering an SDL3 port is inevitable, and will introduce a direct link dependency on SDL3, enabling fixup_bundle to grab SDL3 for us without any of this dancing around.
Dumb idea: What if we linked SDL3 into the openomf target on macos? I wouldn't expect symbol conflicts between sdl2-compat and SDL3, and if the dep survives the linker, we've just successfully told fixup_bundle to copy over the SDL3 that our sdl2-compat needs.
2 participants
No description provided.