Skip to content

Plan Reploy integration delivery - #25

Open
omry wants to merge 1 commit into
pr22from
pr23
Open

Plan Reploy integration delivery#25
omry wants to merge 1 commit into
pr22from
pr23

Conversation

@omry

@omry omry commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Define the bottom-up implementation and review sequence for the accepted Reploy environment, workload Envoy, and protocol contracts. Record slice boundaries, acceptance checks, and the delivery ledger, and update the project backlog accordingly.

Clarify that the alternate rebuild is visible local draft raw material rather than a remote delivery dependency. Link both authoritative design delivery sections to the plan and refresh the existing Reploy environment design attestation.

Preserve the reviewed local backlog and runtime-dependency authority attestations.

Documentation only.


@omry

omry commented Aug 23, 2026

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit by hand.

{
  "approval_evidence": {
    "active_delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
    "candidate_revision_fingerprint": "sha256:8b95e7ddaf291eddd4a3a5d34cef10736a74e3fc3c1f0f887b428f1e01ca245c",
    "finding_dispositions": [
      {
        "design_blocking": true,
        "disposition": "Owner rejected publishing the alternate commits now. Keep them as visible local draft raw material, state that their hashes are temporary, and review any selected content after it is integrated into later stack slices.",
        "id": "R25-durable-raw-material",
        "reviewed_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
        "scope": "current-slice",
        "status": "addressed-reviewed",
        "thread_id": "PRRT_kwDOTOFvvM6bwKfp",
        "thread_status": "resolved",
        "verification_review_id": 5398779720
      },
      {
        "design_blocking": true,
        "disposition": "Add a direct relative link from each existing design Delivery Plan section to the temporary Reploy integration implementation plan.",
        "id": "R25-plan-links",
        "reviewed_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
        "scope": "current-slice",
        "status": "addressed-reviewed",
        "thread_id": "PRRT_kwDOTOFvvM6bwKft",
        "thread_status": "resolved",
        "verification_review_id": 5398779720
      }
    ],
    "required_checks": [
      {
        "bucket": "pass",
        "link": "https://app.gitar.ai",
        "name": "Gitar",
        "state": "SUCCESS"
      },
      {
        "bucket": "pass",
        "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526568094",
        "name": "Package build",
        "state": "SUCCESS"
      },
      {
        "bucket": "pass",
        "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526527664",
        "name": "Python tests",
        "state": "SUCCESS"
      },
      {
        "bucket": "pass",
        "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526528718",
        "name": "Recording integration",
        "state": "SUCCESS"
      },
      {
        "bucket": "pass",
        "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526529088",
        "name": "Website docs",
        "state": "SUCCESS"
      }
    ],
    "review_request": {
      "body_digest": "sha256:297d9216ddd658f2a3df491dc75a6edd961736bdd96284e1d238dee135ce25d8",
      "head_sha": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "id": 5398754495
    },
    "review_result": {
      "body_digest": "sha256:5ced35ae72f4ead94bc45d8ad23ef4b091fdea064acfe4a70452230369f4bdbd",
      "commit_id": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "id": 5398779720,
      "inline_messages": [],
      "kind": "clean-comment",
      "state": "APPROVED"
    },
    "triggered_attestation_preservation": []
  },
  "approval_fingerprint": "sha256:2f419964da4bcfd15e9003c8965e2d1a7b688b2b55333cc03e264492423e75de",
  "approved": true,
  "approved_revision_fingerprint": "sha256:8b95e7ddaf291eddd4a3a5d34cef10736a74e3fc3c1f0f887b428f1e01ca245c",
  "candidate_revision_fingerprint": "sha256:8b95e7ddaf291eddd4a3a5d34cef10736a74e3fc3c1f0f887b428f1e01ca245c",
  "checks": [
    {
      "bucket": "pass",
      "link": "https://app.gitar.ai",
      "name": "Gitar",
      "state": "SUCCESS"
    },
    {
      "bucket": "pass",
      "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526568094",
      "name": "Package build",
      "state": "SUCCESS"
    },
    {
      "bucket": "pass",
      "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526527664",
      "name": "Python tests",
      "state": "SUCCESS"
    },
    {
      "bucket": "pass",
      "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526528718",
      "name": "Recording integration",
      "state": "SUCCESS"
    },
    {
      "bucket": "pass",
      "link": "https://github.com/omry/omegaflow/actions/runs/32754886371/job/97526529088",
      "name": "Website docs",
      "state": "SUCCESS"
    }
  ],
  "cycle_closed": true,
  "deferrals": [],
  "findings": [
    {
      "assessment": "The commits are intentionally local draft raw material, are now visible in Sapling, and are not required delivery inputs. Remote publication is not required before their contents are selectively brought onto the reviewed stack.",
      "claim": "Either publish durable refs or patches, or make the plan independent of these local-only objects.",
      "decision_actor": "owner",
      "decision_reason": "The review is actively progressing locally; the commits will be brought onto the approved stack later rather than published as a competing stack now.",
      "design_blocking": true,
      "disposition": "Owner rejected publishing the alternate commits now. Keep them as visible local draft raw material, state that their hashes are temporary, and review any selected content after it is integrated into later stack slices.",
      "fix_class": "durable-delivery-inputs",
      "id": "R25-durable-raw-material",
      "invariant": "every implementation-plan input needed outside the author checkout is durably reachable",
      "proposed_fix": "Replace the stale hidden-commit wording with visible-local-draft wording, make the non-dependency and temporary-hash status explicit, and remove the obsolete hidden commit access instructions.",
      "proposed_fix_classification": "current-slice representation fix; intentional local-only state remains",
      "resolution": "The plan now identifies the alternate commits as visible local draft raw material, makes them optional rather than delivery prerequisites, labels their hashes temporary, and removes the obsolete hidden-commit access steps.",
      "resulting_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "reviewed_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "scope": "current-slice",
      "severity": "P2",
      "source": "codex",
      "source_body_digest": "sha256:2338c21cfc51640ddb3559c8696ac43de1f348498338e481d13addff2565e1db",
      "source_comment_id": 3844960793,
      "source_head": "186382a78b72bc7781621f48678017c78a807b35",
      "source_review_id": 5009637508,
      "status": "addressed-reviewed",
      "thread_id": "PRRT_kwDOTOFvvM6bwKfp",
      "thread_status": "resolved",
      "title": "Make optional rebuild material durable or remove it as a delivery input",
      "user_disposition_required": false,
      "verification_review_id": 5398779720,
      "where": "docs/design/reploy-integration-implementation-plan.md:47-64"
    },
    {
      "assessment": "real; both delivery sections name an implementation-plan slice without linking this plan",
      "claim": "Add direct links from both design delivery sections and align the plan's own A1 wording.",
      "design_blocking": true,
      "disposition": "Add a direct relative link from each existing design Delivery Plan section to the temporary Reploy integration implementation plan.",
      "fix_class": "delivery-plan-navigation",
      "id": "R25-plan-links",
      "invariant": "authoritative product contracts link directly to the document that owns delivery order and progress evidence",
      "proposed_fix": "Link the existing implementation-plan reference in both design documents without changing their contracts or phase summaries.",
      "proposed_fix_classification": "current-slice representation/navigation fix",
      "resolution": "Both authoritative design Delivery Plan sections now link directly to the Reploy integration implementation plan.",
      "resulting_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "reviewed_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "scope": "current-slice",
      "severity": "P2",
      "source": "codex",
      "source_body_digest": "sha256:116f43e156760ab585728319aed49ce1f9e10179e6f95ec25de1e79e46992350",
      "source_comment_id": 3844960801,
      "source_head": "186382a78b72bc7781621f48678017c78a807b35",
      "source_review_id": 5009637508,
      "status": "addressed-reviewed",
      "thread_id": "PRRT_kwDOTOFvvM6bwKft",
      "thread_status": "resolved",
      "title": "Link the authoritative design documents to the delivery plan",
      "user_disposition_required": false,
      "verification_review_id": 5398779720,
      "where": "docs/design/reploy-integration-implementation-plan.md:129-130"
    }
  ],
  "pr": {
    "base_ref": "pr22",
    "base_sha": "2a5a60129f4d5ac79af228b7041d45368087f56e",
    "body_digest": "sha256:ae61502f0db94823be932cc2485c1909bae046921736894e7b41228b8e1ae764",
    "diff_digest": "sha256:a7c491e65f247815614fa00d92e8722945d562f6038249753a96e542a2e37637",
    "head_ref": "pr23",
    "head_sha": "6d1e566faa80d87d93d7f40131ff8703b42db270",
    "pr": 25,
    "repository": "omry/omegaflow",
    "scope_authority": [
      {
        "digest": "sha256:bfc323c0c0827033b278185c84d36a50137210a257f5d131d68cfaa2b069bca2",
        "path": "docs/.review/BACKLOG.md"
      },
      {
        "digest": "sha256:0f38919d9d8b909b2f5fbd12a3b5371957b1df3c2aaba948e06d958250800a7a",
        "path": "docs/.review/runtime-dependencies.md"
      },
      {
        "digest": "sha256:7c8806d142b11af6603dfc4fd1067005090106c97dcd14d773821315bbb2b03b",
        "path": "docs/BACKLOG.md"
      },
      {
        "digest": "sha256:a3fd7a68f5fafd31a30c97d7196c02e654cc2bc04736c84321ac210d1a0e0b46",
        "path": "docs/design/envoy-protocol-v1.md"
      },
      {
        "digest": "sha256:eb579960ef7ea2b2ba0fe8427fdc47fec93e66c38294d010dfeb99de1565fa0b",
        "path": "docs/design/omegaflow-envoy-design.md"
      },
      {
        "digest": "sha256:4ebbefefe348f30161aec8ea4f6a135acb22c170f0a23e658f38875785e3919a",
        "path": "docs/design/reploy-environments-design.md"
      },
      {
        "digest": "sha256:dad245428e52256b349c805154d089e3220cb28d87288e881f23c161ba1398f2",
        "path": "docs/design/reploy-integration-implementation-plan.md"
      },
      {
        "digest": "sha256:ea989e6cff43e71b8346f226d1eb89db4d246006ce57288ce393928d86f2a349",
        "path": "docs/runtime-dependencies.md"
      }
    ],
    "title_digest": "sha256:11683ddc292ebae8bf576725dbc1d2d44131908731e78d6c9d17682acc718ea2"
  },
  "record_version": 14,
  "review_request": {
    "body_digest": "sha256:297d9216ddd658f2a3df491dc75a6edd961736bdd96284e1d238dee135ce25d8",
    "created_at": "2026-08-24T17:16:42Z",
    "head_sha": "6d1e566faa80d87d93d7f40131ff8703b42db270",
    "id": 5398754495,
    "url": "https://github.com/omry/omegaflow/pull/25#issuecomment-5398754495"
  },
  "review_result": {
    "author": "chatgpt-codex-connector[bot]",
    "body_digest": "sha256:5ced35ae72f4ead94bc45d8ad23ef4b091fdea064acfe4a70452230369f4bdbd",
    "commit_id": "6d1e566faa80d87d93d7f40131ff8703b42db270",
    "id": 5398779720,
    "inline_messages": [],
    "kind": "clean-comment",
    "state": "APPROVED",
    "submitted_at": "2026-08-24T17:18:56Z",
    "url": "https://github.com/omry/omegaflow/pull/25#issuecomment-5398779720"
  },
  "revision_fingerprint": "sha256:8b95e7ddaf291eddd4a3a5d34cef10736a74e3fc3c1f0f887b428f1e01ca245c",
  "rounds": [
    {
      "applied_fix_footprint": [
        "docs/design/reploy-integration-implementation-plan.md",
        "docs/design/omegaflow-envoy-design.md",
        "docs/design/reploy-environments-design.md",
        "docs/design/.review/reploy-environments-design.md"
      ],
      "attempt": 1,
      "disposition_changes": {
        "R25-durable-raw-material": "accepted-fix-planned -> addressed-reviewed",
        "R25-plan-links": "accepted-fix-planned -> addressed-reviewed"
      },
      "effective_diff_digest": "sha256:a7c491e65f247815614fa00d92e8722945d562f6038249753a96e542a2e37637",
      "finding_ids": [
        "R25-durable-raw-material",
        "R25-plan-links"
      ],
      "inline_message_count": 0,
      "invariants": [
        "optional local draft material is not a required delivery input",
        "authoritative product contracts link directly to the delivery plan"
      ],
      "proposed_fix_footprint": [
        "docs/design/reploy-integration-implementation-plan.md",
        "docs/design/omegaflow-envoy-design.md",
        "docs/design/reploy-environments-design.md",
        "docs/design/.review/reploy-environments-design.md"
      ],
      "resulting_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "review_request_id": 5398754495,
      "review_result": "clean",
      "review_result_id": 5398779720,
      "reviewed_head": "6d1e566faa80d87d93d7f40131ff8703b42db270",
      "root_cause_assessment": "The prior revision described optional local rebuild material in a way that could be read as a dependency and left the owning delivery plan unnamed from the two authoritative design documents.",
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 1
}

@omry
omry force-pushed the pr23 branch 2 times, most recently from dfb4a53 to d0e89ff Compare August 23, 2026 15:44
@omry
omry force-pushed the pr23 branch 2 times, most recently from 3d897e6 to 9b0532c Compare August 23, 2026 17:35
@omry
omry force-pushed the pr23 branch 2 times, most recently from 7b7e550 to 3747fcd Compare August 24, 2026 04:06
@omry
omry force-pushed the pr23 branch 2 times, most recently from 9395039 to 6029e41 Compare August 24, 2026 09:25
@omry
omry force-pushed the pr23 branch 2 times, most recently from 7936c9a to a393582 Compare August 24, 2026 12:13
@omry
omry force-pushed the pr23 branch 2 times, most recently from 18e3482 to 186382a Compare August 24, 2026 15:00
@omry
omry marked this pull request as ready for review August 24, 2026 15:25
@omry

omry commented Aug 24, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 186382a

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 186382a78b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/design/reploy-integration-implementation-plan.md Outdated
Comment thread docs/design/reploy-integration-implementation-plan.md
Define the bottom-up implementation and review sequence for the accepted Reploy environment, workload Envoy, and protocol contracts. Record slice boundaries, acceptance checks, and the delivery ledger, and update the project backlog accordingly.

Clarify that the alternate rebuild is visible local draft raw material rather than a remote delivery dependency. Link both authoritative design delivery sections to the plan and refresh the existing Reploy environment design attestation.

Preserve the reviewed local backlog and runtime-dependency authority attestations.

Documentation only.
@gitar-bot

gitar-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Delivers the Plan Reploy integration documentation, defining slice boundaries, contracts, and updating the project backlog. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Aug 24, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 6d1e566

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 6d1e566faa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR reviewed and approved label Aug 24, 2026
omry added a commit that referenced this pull request Aug 25, 2026
Formalize the Envoy -> external Awsh -> persistent selected-shell architecture. Define private helper IPC, PTY and descriptor ownership, command lifecycle reporting, race-safe cancellation and finalization, Bash state preservation, and the behavioral boundary for future shell backends.

Specify delivery of the immutable Bash bootstrap through a manifested trusted rcfile and its startup readiness handshake. Reject the exact Readline bracketed-paste terminator before an operation starts so authored source cannot escape private submission framing.

Align the environment design and implementation plan, and refresh the existing environment-design attestation after clean exact-byte review.

Validation: 998 repository tests, 63 external-supervisor prototype tests, schema documentation check, and Towncrier draft check.

Documentation only. This A2 design successor belongs above PR #25 and below implementation PR #18; production implementation remains blocked until this revision is approved with green checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant