Skip to content

Define portable tool implementation plan - #86

Closed
omry wants to merge 3 commits into
pr82from
pr86
Closed

Define portable tool implementation plan#86
omry wants to merge 3 commits into
pr82from
pr86

Conversation

@omry

@omry omry commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Add a dependency-ordered delivery plan for completing the accepted portable tool definition design through reviewable Java and Playwright slices.

Define the preparation gates that retire the oversized PR 83 and PR 85 work into parked extraction sources, and link the plan from the normative design without changing its decisions.

Scope authority

Intent: establish docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md as the delivery authority for tasks PTD-01 through PTD-24 under the normative Portable Tool Definition Design.

Acceptance criteria:

  • the plan defines one dependency-ordered queue of PTD tasks, each a single review responsibility, commit, and PR;
  • preparation gates describe the completed baseline, WIP retirement, slice ownership rule, stack construction, and delivery handoff;
  • the design document links to the plan without any normative decision changing;
  • nox -s docs-build passes.

Exclusions: no implementation code, no record schemas, no catalog behavior, and no change to the accepted design's decisions. Superseded PRs #83 and #85 are closed; their content is parked locally and delivered later as PTD-01 through PTD-11.

omry added 2 commits August 16, 2026 17:42
Specify the concrete record graph, exact target selection, mixed acquisition, identity, validation, and security model for portable Java and Playwright definitions.

Align the repository and blueprint environment contracts with versioned tool requirements, selected-closure identity, and migration from the interim flat embedded catalog.
Allow exact relative subtree exclusions to be applied before local-source observation and bind them into source identity. Accept valid single-root Python sdists without explicit directory headers while preserving archive safety checks.

Fixes #80
@omry

omry commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit.

{
  "approval": {
    "approved_revision_fingerprint": "sha256:d70f047489815969fe679642916cd56c3451f91df535481de7fa8dd009adea36",
    "evidence_fingerprint": "sha256:f54ef0da5d20ccac5c502c5f3ffafe090b03f6aed58ec226cc0a978ab30a6527",
    "rounds": 9
  },
  "delivery_deferrals": [],
  "findings_summary": {
    "applied": 16,
    "non_actionable": 2,
    "note": "the changelog-fragment finding recurred in all nine rounds and is non-actionable: the fragment is present in every reviewed head since e473525e4668",
    "total": 18
  },
  "pull_request": {
    "base": {
      "ref": "pr82",
      "sha": "17c7dbbbd2a99e583ada4512bff709ac6f661198"
    },
    "head": {
      "ref": "pr86",
      "sha": "0eb14331b9fa58b7e4c62d3e46ef942ebaac470d"
    },
    "number": 86,
    "repository": "github.com/omry/reploy"
  },
  "required_checks": {
    "conclusion": "success",
    "count": 7
  },
  "revision_fingerprint": "sha256:d70f047489815969fe679642916cd56c3451f91df535481de7fa8dd009adea36",
  "scope_authority": {
    "docs/PORTABLE_TOOL_DEFINITION_DESIGN.md": "sha256:a7acc70b0b1e390cd4d7d0e60b0f30e6a17500f6a12828195d4b5e8d083ff536",
    "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md": "sha256:900a01621dacdffd2f391a366a1542bc9f054528bb2175cd6683e5ec839b401a"
  },
  "threads": {
    "open": 0,
    "total": 19
  },
  "version": 5
}

@omry
omry marked this pull request as ready for review August 17, 2026 21:20
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@omry
omry marked this pull request as draft August 17, 2026 21:21
@omry

omry commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

Review request declined by the connector: "You have reached your Codex usage limits for security reviews." No attributable current-head review result exists, so this PR returns to draft and its PR-cycle run is paused, resumable at head 02531926e475.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02531926e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
@omry

omry commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02531926e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md
Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
@omry

omry commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review e473525

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e473525e46

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
@omry

omry commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 742ba53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 742ba53c3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
@omry

omry commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 3f5af63

Note on the repeated changelog finding: .changes/unreleased/portable-tool-delivery-plan.yaml (kind Docs) has been part of this commit since e473525e4668 and is present in 3f5af633c1af245aed30ba8044edd2992e52d30c. If it is still reported, the finding is stale rather than unaddressed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f5af633c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7084147ce4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
@omry

omry commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 6760830

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 676083026a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
@omry

omry commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 0c34f07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c34f07644

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md
Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
@omry

omry commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review cf6832d

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf6832d936

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md Outdated
Add a dependency-ordered delivery plan for completing the accepted portable tool definition design through reviewable Java and Playwright slices.

Define the preparation gates that retire the oversized PR 83 and PR 85 work into parked extraction sources, and link the plan from the normative design without changing its decisions.
@omry

omry commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 0eb1433

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0eb14331b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md
@omry omry added the approved PR reviewed and approved label Aug 18, 2026
@omry
omry marked this pull request as ready for review August 18, 2026 10:59
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0eb14331b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md
@omry

omry commented Aug 21, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded during the bottom-up stack rebuild. This PR’s implementation-plan and design-link responsibility was folded into rebuilt PR #81 at head 5ab6005, where it was materially updated and reviewed as the PTD-01 through PTD-28 authority. Reapplying this PR’s older PTD-01 through PTD-24 diff would regress that authority. The rebuilt stack therefore skips #86; #88 will be rebuilt directly onto #82.

@omry omry closed this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant