RBN format files, inc JSON encoded - #4
Open
kiat-huang wants to merge 1 commit into
Open
kiat-huang wants to merge 1 commit into
kiat-huang wants to merge 1 commit into
Conversation
tameware
reviewed
Jul 27, 2020
tameware
left a comment
tameware
left a comment
Contributor
There was a problem hiding this comment.
Nothing wrong that I can see, but can you add some context, perhaps in a README? I don't know what these files are intended to represent.
Contributor
Author
|
Apologies I should have explained. These files represent the proposed converted end state of an RBN ascii file into JSON format, with examples. They are not needed or suggested to be used programmatically. They can't break anything.
…On Mon, 27 Jul 2020 at 02:22, Adam Wildavsky ***@***.***> wrote:
***@***.**** commented on this pull request.
Nothing wrong that I can see, but can you add some context, perhaps in a
README? I don't know what these files are intended to represent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDQZWZC7VFZR2LS7JEKGDLR5TJD5ANCNFSM4PIHCKYQ>
.
--
Kind regards,
Kiat
linkedin.com/in/kiathuang <https://www.linkedin.com/in/kiathuang/>
bit.ly/bridge-hackathon
bswg.org
www.ebu.co.uk/biographies/kiat-huang
+44-7526-810553
|
Contributor
|
That's fair enough. Would it be a good idea to add a README to the directory containing the text in your comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added RBN related files for RBN - JSON conversion
http://www.rpbridge.net/7a12.htm