Add tests for stack trace filtering in context - #482
Merged
Merged
Conversation
Tests verify that context string values are filtered when shorter stack traces feature is enabled, ensuring vendor paths are replaced with ellipsis while app paths remain.
Fixes Windows test failures by converting CRLF and CR line endings to LF before processing stack traces.
Handle CRLF line endings when JSON contains control characters by replacing both \r\n and \r with escaped newlines during JSON parsing error recovery.
Makes test platform-independent by normalizing line endings when comparing context values on Windows vs Unix systems.
Normalizes line endings in all context values immediately after JSON extraction, ensuring consistent cross-platform behavior regardless of whether filtering is enabled.
Heredocs may contain platform-specific line endings on Windows. Normalize expected value to match the normalized context output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
...) while application paths remain intactTest Coverage
Two new tests added to
LaravelLogsTest.php:Test Results
✅ All 300 tests pass (939 assertions)
✅ Code formatted with Laravel Pint
Related