Fix BaseModel nested model coercion#295
Open
bjedrocha wants to merge 1 commit into
Open
Conversation
Store coerced nested model values during BaseModel construction and assignment instead of preserving raw hashes. Add coverage for nested model fields and arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nested
BaseModelcoercion so generated setters store successfully coerced nested model values instead of preserving the original raw hashes/arrays.Details
Previously, the generated
BaseModelsetter computed coerced nested model values but stored the original raw input while marking the field as successfully coerced. As a result, nestedBaseModelandArrayOf[BaseModel]fields initialized from hashes could remain plainHashvalues.This updates the setter success check to store the coerced value when coercion succeeds, while preserving existing behaviour for already-correct values and failed conversions.
Before / after
Before this fix, the setter computed the coerced Item values but stored the raw input:
After this fix, successful coercion is stored: