Skip to content

CADC-15541: Youcat: update table-ops to match ops WD - #267

Open
aratikakadiya wants to merge 5 commits into
opencadc:v1.1-nextfrom
aratikakadiya:tap-next
Open

CADC-15541: Youcat: update table-ops to match ops WD#267
aratikakadiya wants to merge 5 commits into
opencadc:v1.1-nextfrom
aratikakadiya:tap-next

Conversation

@aratikakadiya

Copy link
Copy Markdown
Contributor
  • Added support for multicolumn index -- updated params structure according to the openapi doc.
  • Added int test to test unique and multicolumn index with latest param structure.

- Added support for multicolumn index
- Added int test to test unique and multicolumn index with latest param structure.

@brianmajor brianmajor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look and generally the code looks quite well constructed. I like how you plan to transition to the multi-column index by just throwing the UnsupportedOperationException for now, but having the framework in place. I will leave this to @pdowler to complete the merge when ready.

Updated int test to validate index creation success for long-lat index type and failure for x-y index type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants