Repository navigation
Conversation
readJson labeled every thrown error as malformed JSON. Reading a directory, hitting EACCES, or a disappearing file after existsSync all produced that message. Keep the wrapper for SyntaxError only. Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
readJsoncaught every failure fromreadFileSyncandJSON.parseand rethrew it asmalformed JSON. A directory whose name ends in.json, a permission error, or a file that vanishes afterexistsSyncall looked like a parse bug. Parse failures should stay labeled that way. I/O failures should keep their originalcode.Evidence
Live
nodeimport ofreadJsonon the patched tree. A path that is a directory throwsEISDIRwith nomalformed JSONtext. Truncated JSON still throws the wrapped parse message.Real behavior proof
readJsonkeep their original Nodecode. OnlyJSON.parseSyntaxErroris wrapped as malformed JSON.scripts/source.mjson branchfix/readjson-syntaxerror-only.run.jsonas a directory and a siblingbad.jsonwith truncated JSON. ImportedreadJsonfrom./scripts/source.mjswithnode --input-type=moduleand called it on both paths.nodecommand (see Evidence). The directory path printsEISDIRandillegal operation on a directory. The truncated file prints the wrapped malformed JSON message.readJsonrethrows non-SyntaxErrorvalues unchanged, so operators seeEISDIRinstead of a fake parse failure.EACCESon a locked file.Change
scripts/source.mjswrapsSyntaxErroronly.Origin
Introduced in
7964f2af5f7.