Repository navigation
Conversation
A non-URL target such as cluster:... was rendered as a link to itself and hid action.pr and action.url. Link those first, and leave cluster targets unlinked. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A repair action whose target was
cluster:...was rendered as a link to that text. That hid a real pull or issue URL stored on the same action.Why This Change Was Made
targetLinklinksaction.proraction.urlwhen either is a GitHub issue or pull URL. Acluster:target is left as plain text.scripts/repair-dashboard.mjstest/repair-dashboard.test.mjsUser Impact
A blocked cluster repair shows the pull number as a link. A completed close shows the issue number as a link. The
cluster:target is not a link.Evidence
renderRepairDashboardfrom commit0c3156eread one run file. The fix action target wascluster:issue-openclaw-openclaw-5and its pull URL washttps://github.com/openclaw/openclaw/pull/9. The apply action target wascluster:issue-openclaw-openclaw-8and its issue URL washttps://github.com/openclaw/openclaw/issues/8.cluster_linksis the count of markdown links whose destination starts withcluster:.Real behavior proof
cluster:repair target is not linked. The action's pull or issue URL is linked instead.renderRepairDashboardfrom commit0c3156e, one JSON run file under a temporary results directory.cluster:issue-openclaw-openclaw-5and whosepris pull 9. Write an apply action whose target iscluster:issue-openclaw-openclaw-8and whoseurlis issue 8. Render the dashboard.[#9](https://github.com/openclaw/openclaw/pull/9). The completed row links[#8](https://github.com/openclaw/openclaw/issues/8).cluster_linksis 0.statebranch. The render read a local results directory.