Repository navigation
fix: isolate release QA credentials between concurrent agents - #71
Merged
steipete merged 2 commits intoSep 23, 2026
Conversation
…hes atomically Seeding agents that target candidate release auth runtimes previously swapped OPENCLAW_STATE_DIR on the shared process env across an await boundary, letting concurrent Promise.all seeding observe or clobber each other's state root. The candidate serializer now runs in a one-shot child process whose env carries exactly the seeding agent's state dir; the parent never mutates its own env. Multi-file patch writes now stage sibling .tmp- files and move them into place with fs.rename, restoring already-moved files (best effort) when a later rename fails and reporting paths that still need manual recovery. Patched-store assertions and worker merge/replace semantics are covered by overlapping two-agent seeding, fail-closed runtime contract, and fault-injected staging/rename rollback tests. refs openclaw/openclaw#119679
steipete
force-pushed
the
fix/qa-rtt-atomic-patch-isolated-serialization
branch
from
September 23, 2026 07:59
fdb7d73 to
de0d192
Compare
steipete
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: openclaw/openclaw#119679
What Problem This Solves
Fixes concurrent release QA agents writing credentials under another agent’s state directory and prevents failed compatibility patches from leaving a partly updated harness.
User Impact
Release QA seeding preserves the parent environment and isolates each agent’s candidate auth runtime. Failed patch commits attempt to restore the original files, preserve permissions, and identify any files needing manual recovery.
Why This Change Was Made
Candidate runtimes cache paths during import, so temporarily changing the shared environment cannot safely isolate concurrent agents. Each serialization now runs in a bounded child process. File changes are staged in unique sibling directories before replacement; rollback is best effort across the file set, not a filesystem transaction.
Finishes @petercheng’s original fix with subprocess error handling, collision-free staging, preserved file modes, and tests that execute the generated auth writer. Removes the unused in-process runtime loader. The linked issue also mentions a retired Telegram helper; this PR covers the active release QA patcher only.
Evidence
0600and unrelated staging files.npm run checkpassed data validation and unchanged README generation.de0d19282803034f3ec22eda536eeea1cce334ca: https://github.com/openclaw/openclaw-rtt/actions/runs/35834657972