CI lint checks failing

[lm2612]

Since updating .github/workflows, branch_ci lint checks are failing. Possibly due to different python and ruff versions now we are using uv lock files.
Lint checks pass with .github/workflows v1.9.0
We should update code to avoid lint check errors so that lint checks pass with most recent workflows

[lm2612]

This is due to ruff being updated to 0.16.
Full list of linting errors:

C408 Unnecessary `dict()` call (rewrite as a literal)
  --> pvnet/datamodule.py:63:42
   |
61 |           self.dataset_pickle_dir = dataset_pickle_dir
62 |
63 |           self._common_dataloader_kwargs = dict(
   |  __________________________________________^
64 | |             batch_size=batch_size,
65 | |             batch_sampler=None,
66 | |             num_workers=num_workers,
67 | |             collate_fn=collate_fn,
68 | |             pin_memory=pin_memory,
69 | |             timeout=0,
70 | |             worker_init_fn=None,
71 | |             prefetch_factor=prefetch_factor,
72 | |             persistent_workers=persistent_workers,
73 | |             multiprocessing_context="spawn" if num_workers > 0 else None,
74 | |         )
   | |_________^
75 |
76 |       def setup(self, stage: str | None = None):
   |
help: Rewrite as a literal

SIM102 Use a single `if` statement instead of nested `if` statements
  --> pvnet/models/base_model.py:37:9
   |
36 |       for source in ["generation", "satellite"]:
37 | /         if source in input_config:
38 | |             # If not empty - i.e. if used
39 | |             if input_config[source]["zarr_path"] != "":
   | |_______________________________________________________^
40 |                   input_config[source]["zarr_path"] = f"{placeholder}.zarr"
   |
help: Combine `if` statements using `and`

SIM102 Use a single `if` statement instead of nested `if` statements
   --> pvnet/models/base_model.py:104:5
    |
102 |               )
103 |
104 | /     if "pv" in input_config:
105 | |         if not model.include_pv:
    | |________________________________^
106 |               del input_config["pv"]
    |
help: Combine `if` statements using `and`

TRY002 Create your own exception
   --> pvnet/models/base_model.py:166:23
    |
164 |           except Exception as e:
165 |               if attempt == max_retries:
166 |                   raise Exception(
    |  _______________________^
167 | |                     f"Failed to download {filename} from {repo_id} after {max_retries} attempts."
168 | |                 ) from e
    | |_________________^
169 |               logging.warning(
170 |                   (
    |

LOG015 `warning()` call on root logger
   --> pvnet/models/base_model.py:169:13
    |
167 |                       f"Failed to download {filename} from {repo_id} after {max_retries} attempts."
168 |                   ) from e
169 | /             logging.warning(
170 | |                 (
171 | |                     f"Attempt {attempt}/{max_retries} failed to download {filename} "
172 | |                     f"from {repo_id}. Retrying in {wait_time} seconds..."
173 | |                 )
174 | |             )
    | |_____________^
175 |               time.sleep(wait_time)
    |
help: Use own logger instead

UP034 [*] Avoid extraneous parentheses
   --> pvnet/models/base_model.py:170:17
    |
168 |                   ) from e
169 |               logging.warning(
170 | /                 (
171 | |                     f"Attempt {attempt}/{max_retries} failed to download {filename} "
172 | |                     f"from {repo_id}. Retrying in {wait_time} seconds..."
173 | |                 )
    | |_________________^
174 |               )
175 |               time.sleep(wait_time)
    |
help: Remove extraneous parentheses
    |
169 |             logging.warning(
    -                 (
170 +                 
171 |                     f"Attempt {attempt}/{max_retries} failed to download {filename} "
172 |                     f"from {repo_id}. Retrying in {wait_time} seconds..."
    -                 )
173 +                 
174 |             )
    |

PLR1711 [*] Useless `return` statement at end of function
   --> pvnet/models/base_model.py:346:9
    |
344 |             print(message)
345 |
346 |         return
    |         ^^^^^^
347 |
348 |     @staticmethod
    |
help: Remove useless `return` statement
    |
345 |
    -         return
346 |
    |

C419 Unnecessary list comprehension
  --> pvnet/models/ensemble.py:45:24
   |
43 |             interval_minutes,
44 |         ]:
45 |             assert all([p == param_list[0] for p in param_list]), param_list
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
46 |
47 |         super().__init__(
   |
help: Remove unnecessary comprehension

PIE790 [*] Unnecessary `pass` statement
  --> pvnet/models/late_fusion/encoders/basic_blocks.py:39:9
   |
37 |     def forward(self):
38 |         """Run model forward"""
39 |         pass
   |         ^^^^
   |
help: Remove unnecessary `pass`
   |
38 |         """Run model forward"""
   -         pass
39 |
   |

PIE808 [*] Unnecessary `start` argument in `range`
  --> pvnet/models/late_fusion/encoders/encoders3d.py:87:24
   |
85 |             nn.ELU(),
86 |         ]
87 |         for _ in range(0, number_of_conv3d_layers - 1):
   |                        ^
88 |             conv_layers += [
89 |                 nn.Conv3d(
   |
help: Remove `start` argument
   |
86 |         ]
   -         for _ in range(0, number_of_conv3d_layers - 1):
87 +         for _ in range(number_of_conv3d_layers - 1):
88 |             conv_layers += [
   |

SIM118 Use `key in dict` instead of `key in dict.keys()`
   --> pvnet/models/late_fusion/late_fusion.py:194:17
    |
192 |                 self.nwp_embed_dict = torch.nn.ModuleDict()
193 |
194 |             for nwp_source in nwp_encoders_dict.keys():
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
195 |                 nwp_sequence_len = (
196 |                     nwp_history_minutes[nwp_source] // nwp_interval_minutes[nwp_source]
    |
help: Remove `.keys()`

TRY004 Prefer `TypeError` exception for invalid type
  --> pvnet/models/late_fusion/linear_networks/basic_blocks.py:32:13
   |
30 |             return x
31 |         else:
32 |             raise ValueError(f"Input of unexpected type {type(x)}")
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
33 |
34 |     @abstractmethod
   |

PIE790 [*] Unnecessary `pass` statement
  --> pvnet/models/late_fusion/linear_networks/basic_blocks.py:37:9
   |
35 |     def forward(self, x: OrderedDict[str, torch.Tensor] | torch.Tensor) -> torch.Tensor:
36 |         """Run model forward"""
37 |         pass
   |         ^^^^
   |
help: Remove unnecessary `pass`
   |
36 |         """Run model forward"""
   -         pass
37 |
   |

PIE790 [*] Unnecessary `pass` statement
  --> pvnet/models/late_fusion/site_encoders/basic_blocks.py:36:9
   |
34 |     def forward(self) -> torch.Tensor:
35 |         """Run model forward"""
36 |         pass
   |         ^^^^
   |
help: Remove unnecessary `pass`
   |
35 |         """Run model forward"""
   -         pass
   |

PIE790 [*] Unnecessary `pass` statement
  --> pvnet/optimizers.py:70:9
   |
68 |     def __call__(self, model: Module):
69 |         """Abstract call"""
70 |         pass
   |         ^^^^
   |
help: Remove unnecessary `pass`
   |
69 |         """Abstract call"""
   -         pass
70 |
   |

SIM118 Use `key in dict` instead of `key in dict.keys()`
   --> pvnet/optimizers.py:169:13
    |
167 |         group_args = []
168 |
169 |         for key in self.lr.keys():
    |             ^^^^^^^^^^^^^^^^^^^^^
170 |             if key == "default":
171 |                 continue
    |
help: Remove `.keys()`

C408 Unnecessary `dict()` call (rewrite as a literal)
   --> pvnet/training/lightning_module.py:171:23
    |
170 |           ds_preds_batch = xr.Dataset(
171 |               data_vars=dict(
    |  _______________________^
172 | |                 y_hat=(["sample_num", "forecast_step", "p_level"], y_hat),
173 | |                 y=(["sample_num", "forecast_step"], y),
174 | |             ),
    | |_____________^
175 |               coords=dict(
176 |                   ids=("sample_num", ids),
    |
help: Rewrite as a literal

C408 Unnecessary `dict()` call (rewrite as a literal)
   --> pvnet/training/lightning_module.py:175:20
    |
173 |                   y=(["sample_num", "forecast_step"], y),
174 |               ),
175 |               coords=dict(
    |  ____________________^
176 | |                 ids=("sample_num", ids),
177 | |                 init_times_utc=("sample_num", init_times_utc),
178 | |                 p_level=p_levels,
179 | |             ),
    | |_____________^
180 |           )
181 |           self.all_val_results.append(ds_preds_batch)
    |
help: Rewrite as a literal

PERF102 When using only the values of a dict use the `values()` method
  --> pvnet/training/train.py:67:27
   |
65 |     loggers: list[Logger] = []
66 |     if "logger" in config:
67 |         for _, lg_conf in config.logger.items():
   |                           ^^^^^^^^^^^^^^^^^^^
68 |             loggers.append(hydra.utils.instantiate(lg_conf))
   |
help: Replace `.items()` with `.values()`

PERF102 When using only the values of a dict use the `values()` method
  --> pvnet/training/train.py:73:27
   |
71 |     callbacks: list[Callback] = []
72 |     if "callbacks" in config:
73 |         for _, cb_conf in config.callbacks.items():
   |                           ^^^^^^^^^^^^^^^^^^^^^^
74 |             callbacks.append(hydra.utils.instantiate(cb_conf))
   |
help: Replace `.items()` with `.values()`

SIM118 Use `key in dict` instead of `key in dict.keys()`
  --> scripts/backtest.py:93:13
   |
91 |     if "nwp" in config["input_data"]:
92 |         nwp_config = config["input_data"]["nwp"]
93 |         for nwp_source in nwp_config.keys():
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
94 |             provider = nwp_config[nwp_source]["provider"]
95 |             assert provider in data_paths["nwp"], f"Missing NWP path: {provider}"
   |
help: Remove `.keys()`

C408 Unnecessary `dict()` call (rewrite as a literal)
   --> scripts/backtest.py:328:18
    |
327 |           dims = ["init_time_utc", "location_id", "step"]
328 |           coords = dict(
    |  __________________^
329 | |             init_time_utc=[t0],
330 | |             location_id=location_ids,
331 | |             step=self.steps,
332 | |         )
    | |_________^
333 |
334 |           if output_quantiles is not None:
    |
help: Rewrite as a literal

B008 Do not perform function call `typer.Argument` in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
  --> scripts/checkpoint_to_huggingface.py:33:39
   |
31 | @app.command()
32 | def push_to_huggingface(
33 |     checkpoint_dir_paths: list[str] = typer.Argument(...,),
   |                                       ^^^^^^^^^^^^^^^^^^^^
34 |     huggingface_repo: str = typer.Option(..., "--huggingface-repo"),
35 |     wandb_repo: str = typer.Option(..., "--wandb-repo"),
   |

B008 Do not perform function call `typer.Option` in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
  --> scripts/checkpoint_to_huggingface.py:37:28
   |
35 |     wandb_repo: str = typer.Option(..., "--wandb-repo"),
36 |     card_template_path: str = typer.Option(..., "--card-template-path"),
37 |     wandb_ids: list[str] = typer.Option([], "--wandb-id"),
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
38 |     val_best: bool = typer.Option(True),
39 |     local_path: str = typer.Option(None, "--local-path"),
   |

TRY002 Create your own exception
  --> scripts/checkpoint_to_huggingface.py:69:23
   |
67 |                 wandb_ids.append(dirname)
68 |             else:
69 |                 raise Exception(f"Could not find wand run for {path} within {wandb_repo}")
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
70 |     
71 |     # Else if they are provided check that they exist
   |

TRY002 Create your own exception
  --> scripts/checkpoint_to_huggingface.py:75:23
   |
73 |         for wandb_id in wandb_ids:
74 |             if wandb_id not in all_wandb_ids:
75 |                 raise Exception(f"Could not find wand run for {path} within {wandb_repo}")
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
76 |
77 |     (
   |

SIM102 Use a single `if` statement instead of nested `if` statements
  --> scripts/migrate_old_model.py:76:5
   |
74 |   # This parameter has been removed
75 |   if "target_key" in model_config:
76 | /     if model_config["target_key"] == "site":
77 | |         if "include_site_yield_history" in model_config:
   | |________________________________________________________^
78 |               model_config["include_generation_history"] = model_config.pop(
79 |                   "include_site_yield_history"
   |
help: Combine `if` statements using `and`

SIM102 Use a single `if` statement instead of nested `if` statements
  --> scripts/migrate_old_model.py:82:5
   |
80 |               )
81 |
82 | /     if model_config["target_key"] == "gsp" or not model_config["target_key"]:
83 | |         if "include_site_yield_history" in model_config:
   | |________________________________________________________^
84 |               del model_config["include_site_yield_history"]
   |
help: Combine `if` statements using `and`

TRY002 Create your own exception
   --> scripts/migrate_old_model.py:99:11
    |
 97 |     pass
 98 | else:
 99 |     raise Exception("Unknown model: " + model_config["_target_"])
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
100 |
101 | # Re-find the model components in the new package structure
    |

PERF102 When using only the values of a dict use the `values()` method
   --> scripts/migrate_old_model.py:103:17
    |
101 | # Re-find the model components in the new package structure
102 | if model_config.get("nwp_encoders_dict", None) is not None:
103 |     for k, v in model_config["nwp_encoders_dict"].items():
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
104 |         v["_target_"] = (
105 |             v["_target_"]
    |
help: Replace `.items()` with `.values()`

DTZ011 `datetime.date.today()` used
   --> scripts/migrate_old_model.py:157:20
    |
155 | # Add a note to the model card to say the model has been migrated
156 | with open(f"{save_dir}/{MODEL_CARD_NAME}", "a") as f:
157 |     current_date = datetime.date.today().strftime("%Y-%m-%d")
    |                    ^^^^^^^^^^^^^^^^^^^^^
158 |     pvnet_version = version("pvnet")
159 |     f.write(
    |
help: Use `datetime.datetime.now(tz=...).date()` instead

SIM118 [*] Use `key in dict` instead of `key in dict.keys()`
   --> scripts/scorecard/generate_scorecard.py:139:9
    |
138 |     # Add model name dimension to each backtest
139 |     for model in backtest_dict.keys():
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
140 |         if type(backtest_dict[model]) is list:
141 |             ds = xr.open_mfdataset(backtest_dict[model], engine="zarr")
    |
help: Remove `.keys()`
    |
138 |     # Add model name dimension to each backtest
    -     for model in backtest_dict.keys():
139 +     for model in backtest_dict:
140 |         if type(backtest_dict[model]) is list:
    |

PLC0206 Extracting value from dictionary without calling `.items()`
   --> scripts/scorecard/generate_scorecard.py:139:9
    |
138 |     # Add model name dimension to each backtest
139 |     for model in backtest_dict.keys():
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
140 |         if type(backtest_dict[model]) is list:
    |                 --------------------
141 |             ds = xr.open_mfdataset(backtest_dict[model], engine="zarr")
    |                                    --------------------
142 |             ds = ds.drop_duplicates(dim='init_time_utc')
143 |         else:
144 |             ds = xr.open_zarr(backtest_dict[model])
    |                               --------------------
145 |             
146 |         ds = ds.expand_dims(dict(model=[model]))
    |
help: Use `for model, value in backtest_dict.items()` instead

C408 Unnecessary `dict()` call (rewrite as a literal)
   --> scripts/scorecard/generate_scorecard.py:146:29
    |
144 |             ds = xr.open_zarr(backtest_dict[model])
145 |             
146 |         ds = ds.expand_dims(dict(model=[model]))
    |                             ^^^^^^^^^^^^^^^^^^^
147 |         backtest_ds_list.append(ds)
    |
help: Rewrite as a literal

Found 34 errors.
[*] 8 fixable with the `--fix` option (14 hidden fixes can be enabled with the `--unsafe-fixes` option).

[lm2612]

8 of these can automatically be fixed. The rest I am going through and fixing if its a small change. Otherwise, I will put into ignore in pyproject.toml. The ones I can't easily address are:

• "TRY002", # Create your own exception
• "LOG015", # warning() call on root logger
• "B008", # Do not perform function call typer.Argument