Branch ci lint typecheck fix

[lm2612]

Pull Request

Description

Following .github/workflows changes and ruff update to v0.16, some linting issues were flagged which leads to CI failing. I have implementing some fixes to the code and added some ignore error codes to the pyproject.toml for the following:

• "TRY002", # Create your own exception
• "LOG015", # warning() call on root logger
• "B008", # Do not perform function call typer.Argument

Fixes #537

How Has This Been Tested?

The updates should not change any of the code. pytests still run. I've also tested that I can train pvnet

• Yes

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[lm2612]

Avoids the following errors which I was unsure how to deal with:

TRY002 Create your own exception
   --> pvnet/models/base_model.py:166:23
    |
164 |           except Exception as e:
165 |               if attempt == max_retries:
166 |                   raise Exception(
    |  _______________________^
167 | |                     f"Failed to download {filename} from {repo_id} after {max_retries} attempts."
168 | |                 ) from e


LOG015 `warning()` call on root logger
   --> pvnet/models/base_model.py:169:13
    |
167 |                       f"Failed to download {filename} from {repo_id} after {max_retries} attempts."
168 |                   ) from e
169 | /             logging.warning(
170 | |                 (
171 | |                     f"Attempt {attempt}/{max_retries} failed to download {filename} "
172 | |                     f"from {repo_id}. Retrying in {wait_time} seconds..."
173 | |                 )
174 | |             )

B008 Do not perform function call `typer.Argument` in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
  --> scripts/checkpoint_to_huggingface.py:33:39
   |
31 | @app.command()
32 | def push_to_huggingface(
33 |     checkpoint_dir_paths: list[str] = typer.Argument(...,),
   |                                       ^^^^^^^^^^^^^^^^^^^^
34 |     huggingface_repo: str = typer.Option(..., "--huggingface-repo"),
35 |     wandb_repo: str = typer.Option(..., "--wandb-repo"),

[peterdudfield]

Should add logger = logging.getLogger(__name__)

[peterdudfield]

try to remove this, using logger = logging.getLogger(__name__)

[peterdudfield]

happy to ignore TRY002 and B008

[peterdudfield]

Approved, but good to change logger warning