Fix Space thumbnail preview URLs#174
Open
zerox80 wants to merge 1 commit into
Open
Conversation
8894208 to
5c49dae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #171.
This updates Android thumbnail preview URL generation so files inside Spaces use the Space WebDAV endpoint instead of the legacy
/webdavpath. Space files now resolve previews through/dav/spaces/{spaceId}/..., matching the backend thumbnail routes forSpacesThumbnail.Root cause
ThumbnailsRequesteralways built file preview URLs as{baseUrl}/webdav{remotePath}?preview=1. That works for personal files, but images inside Space subfolders need to be requested via the Space WebDAV URL, e.g./dav/spaces/{spaceId}/{folder}/image.jpg?preview=1.Backend context:
services/webdav/pkg/service/v0/service.goregisters both/dav/spaces/{id}and/remote.php/dav/spaces/{id}for Space thumbnail requests.Changes
OCFileWithSyncInfo.space.root.webDavUrlwhen available.{accountBaseUrl}/dav/spaces/{spaceId}for Space files without attached Space metadata.{accountBaseUrl}/webdav.Validation
./gradlew.bat :opencloudApp:testOriginalDebugUnitTest --tests eu.opencloud.android.presentation.thumbnails.ThumbnailsRequesterTest --no-daemon./gradlew.bat detekt --no-daemon./gradlew.bat assembleDebug --no-daemon