feat: Verify sym_name attribute on func.func and llvm.func#1079
Open
naveen-seth wants to merge 2 commits into
Open
feat: Verify sym_name attribute on func.func and llvm.func#1079naveen-seth wants to merge 2 commits into
naveen-seth wants to merge 2 commits into
Conversation
func.func and llvm.func require the sym_name attribute, but this is not currently enforced and many tests do not declare it. This is now enforced by the verifier. This PR is split into two commits to make review easier: The first adds the check itself and tests the expected error message. The second updates existing tests that were missing sym_name. This was automated with a script: functions are now named foo, bar, baz, or f0, f1, ... when there are more than three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
func.funcandllvm.funcrequire thesym_nameattribute, but this is not currently enforced and many tests do not declare it.This is now enforced by the verifier.
This PR is split into two commits to make review easier:
The first adds the check itself and tests for the expected error message.
The second updates existing tests that were missing
sym_name.This was automated with a script: functions are now named
foo,bar,baz, orf0,f1, ... when there are more than three.