feat(dominance): Add hasSSADominance to OpInfo#1090
Open
math-fehr wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: 673574f | Previous: e0005b3 | Ratio |
|---|---|---|---|
add-fold-worklist/create |
2326000 ns (± 41167) |
1890000 ns (± 82875) |
1.23 |
add-fold-worklist/rewrite |
3937000 ns (± 19804) |
3516000 ns (± 30434) |
1.12 |
add-fold-worklist-local/create |
2544000 ns (± 120442) |
1921000 ns (± 75108) |
1.32 |
add-fold-worklist-local/rewrite |
3787000 ns (± 37461) |
3345000 ns (± 30656) |
1.13 |
add-zero-worklist/create |
2392000 ns (± 118536) |
1906000 ns (± 93003) |
1.25 |
add-zero-worklist/rewrite |
2574000 ns (± 53459) |
2282500 ns (± 46006) |
1.13 |
add-zero-reuse-worklist/create |
2022500 ns (± 134950) |
1564000 ns (± 28018) |
1.29 |
add-zero-reuse-worklist/rewrite |
2143000 ns (± 35219) |
1879000 ns (± 25929) |
1.14 |
mul-two-worklist/create |
2540500 ns (± 124853) |
1908000 ns (± 45497) |
1.33 |
mul-two-worklist/rewrite |
5662500 ns (± 113884) |
5040000 ns (± 247290) |
1.12 |
add-fold-forwards/create |
2476000 ns (± 98825) |
1897000 ns (± 96247) |
1.31 |
add-fold-forwards/rewrite |
3014000 ns (± 41731) |
2651000 ns (± 33111) |
1.14 |
add-zero-forwards/create |
2563500 ns (± 172216) |
1883000 ns (± 75744) |
1.36 |
add-zero-forwards/rewrite |
1987000 ns (± 27732) |
1705000 ns (± 29513) |
1.17 |
add-zero-reuse-forwards/create |
2018000 ns (± 73543) |
1595000 ns (± 79100) |
1.27 |
add-zero-reuse-forwards/rewrite |
1571000 ns (± 13038) |
1366000 ns (± 58799) |
1.15 |
mul-two-forwards/create |
2390000 ns (± 83257) |
1898000 ns (± 90461) |
1.26 |
mul-two-forwards/rewrite |
3831000 ns (± 132483) |
3187000 ns (± 87416) |
1.20 |
add-zero-reuse-first/create |
1980500 ns (± 131634) |
1582500 ns (± 67037) |
1.25 |
add-zero-reuse-first/rewrite |
8000 ns (± 1622) |
10000 ns (± 2236) |
0.80 |
add-zero-lots-of-reuse-first/create |
2118000 ns (± 94722) |
1578000 ns (± 55869) |
1.34 |
add-zero-lots-of-reuse-first/rewrite |
806000 ns (± 19665) |
775000 ns (± 15515) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
tobiasgrosser
approved these changes
Jul 16, 2026
Collaborator
Author
|
I'll wait for @regehr review on this one, as he touched this part recently |
math-fehr
force-pushed
the
math-fehr/regionkind-opinfo
branch
from
July 17, 2026 13:53
d67e2f2 to
6420c59
Compare
math-fehr
force-pushed
the
math-fehr/regionkind-opinfo
branch
from
July 18, 2026 14:55
6420c59 to
673574f
Compare
tobiasgrosser
approved these changes
Jul 18, 2026
tobiasgrosser
left a comment
Collaborator
There was a problem hiding this comment.
This looks fine to me.
Collaborator
|
Also, I feel @regehr is on holidays. Given that the patch is not super complex, I feel it may be safe to merge. |
luisacicolini
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the region kind interface to
OpInfo, out ofOpCode.This will allow to make more generic functions that would work with any dialects.