feat(verifier): Add check that successors have the same parents#1091
Open
math-fehr wants to merge 1 commit into
Open
feat(verifier): Add check that successors have the same parents#1091math-fehr wants to merge 1 commit into
math-fehr wants to merge 1 commit into
Conversation
math-fehr
force-pushed
the
math-fehr/verifier-regions
branch
from
July 16, 2026 18:54
cf36d0d to
02416b5
Compare
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: fd10491 | Previous: e0005b3 | Ratio |
|---|---|---|---|
add-fold-worklist/create |
1892000 ns (± 46036) |
1890000 ns (± 82875) |
1.00 |
add-fold-worklist/rewrite |
3680000 ns (± 41896) |
3516000 ns (± 30434) |
1.05 |
add-fold-worklist-local/create |
1880000 ns (± 17743) |
1921000 ns (± 75108) |
0.98 |
add-fold-worklist-local/rewrite |
3522000 ns (± 38399) |
3345000 ns (± 30656) |
1.05 |
add-zero-worklist/create |
1864000 ns (± 78948) |
1906000 ns (± 93003) |
0.98 |
add-zero-worklist/rewrite |
2331000 ns (± 28385) |
2282500 ns (± 46006) |
1.02 |
add-zero-reuse-worklist/create |
1560000 ns (± 15758) |
1564000 ns (± 28018) |
1.00 |
add-zero-reuse-worklist/rewrite |
1931000 ns (± 35520) |
1879000 ns (± 25929) |
1.03 |
mul-two-worklist/create |
1876500 ns (± 93744) |
1908000 ns (± 45497) |
0.98 |
mul-two-worklist/rewrite |
5158500 ns (± 17709) |
5040000 ns (± 247290) |
1.02 |
add-fold-forwards/create |
1904000 ns (± 88189) |
1897000 ns (± 96247) |
1.00 |
add-fold-forwards/rewrite |
2680000 ns (± 32098) |
2651000 ns (± 33111) |
1.01 |
add-zero-forwards/create |
1886000 ns (± 69686) |
1883000 ns (± 75744) |
1.00 |
add-zero-forwards/rewrite |
1734000 ns (± 25203) |
1705000 ns (± 29513) |
1.02 |
add-zero-reuse-forwards/create |
1545000 ns (± 75761) |
1595000 ns (± 79100) |
0.97 |
add-zero-reuse-forwards/rewrite |
1391000 ns (± 64442) |
1366000 ns (± 58799) |
1.02 |
mul-two-forwards/create |
1893000 ns (± 86467) |
1898000 ns (± 90461) |
1.00 |
mul-two-forwards/rewrite |
3239000 ns (± 105949) |
3187000 ns (± 87416) |
1.02 |
add-zero-reuse-first/create |
1561500 ns (± 72468) |
1582500 ns (± 67037) |
0.99 |
add-zero-reuse-first/rewrite |
9500 ns (± 1918) |
10000 ns (± 2236) |
0.95 |
add-zero-lots-of-reuse-first/create |
1551000 ns (± 20876) |
1578000 ns (± 55869) |
0.98 |
add-zero-lots-of-reuse-first/rewrite |
754000 ns (± 5431) |
775000 ns (± 15515) |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
math-fehr
force-pushed
the
math-fehr/verifier-regions
branch
2 times, most recently
from
July 16, 2026 23:09
9c1b046 to
b9f8834
Compare
tobiasgrosser
approved these changes
Jul 17, 2026
math-fehr
force-pushed
the
math-fehr/regionkind-opinfo
branch
from
July 17, 2026 13:53
d67e2f2 to
6420c59
Compare
math-fehr
force-pushed
the
math-fehr/verifier-regions
branch
from
July 18, 2026 14:55
b9f8834 to
fd10491
Compare
math-fehr
force-pushed
the
math-fehr/regionkind-opinfo
branch
from
July 18, 2026 14:55
6420c59 to
673574f
Compare
luisacicolini
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two checks on regions: