feat: modularize remaining files in Veir/#1098
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: 0778734 | Previous: fb545eb | Ratio |
|---|---|---|---|
add-fold-worklist/create |
1936000 ns (± 33811) |
2013000 ns (± 16727) |
0.96 |
add-fold-worklist/rewrite |
3650000 ns (± 97454) |
3242000 ns (± 58202) |
1.13 |
add-fold-worklist-local/create |
1913000 ns (± 80320) |
2010000 ns (± 7918) |
0.95 |
add-fold-worklist-local/rewrite |
3402000 ns (± 78152) |
3123000 ns (± 21138) |
1.09 |
add-zero-worklist/create |
1922000 ns (± 34259) |
2025000 ns (± 16514) |
0.95 |
add-zero-worklist/rewrite |
2447000 ns (± 82198) |
2130000 ns (± 62638) |
1.15 |
add-zero-reuse-worklist/create |
1611000 ns (± 26939) |
1656000 ns (± 28879) |
0.97 |
add-zero-reuse-worklist/rewrite |
2041000 ns (± 90183) |
1841000 ns (± 15388) |
1.11 |
mul-two-worklist/create |
1927000 ns (± 24413) |
2015000 ns (± 19812) |
0.96 |
mul-two-worklist/rewrite |
5261000 ns (± 265377) |
4645000 ns (± 8877) |
1.13 |
add-fold-forwards/create |
1942000 ns (± 85004) |
2021000 ns (± 26633) |
0.96 |
add-fold-forwards/rewrite |
2729000 ns (± 28588) |
2587000 ns (± 32608) |
1.05 |
add-zero-forwards/create |
2003000 ns (± 62343) |
2033000 ns (± 91404) |
0.99 |
add-zero-forwards/rewrite |
1789000 ns (± 30655) |
1689000 ns (± 19857) |
1.06 |
add-zero-reuse-forwards/create |
1626000 ns (± 40079) |
1645000 ns (± 75817) |
0.99 |
add-zero-reuse-forwards/rewrite |
1424000 ns (± 64006) |
1404000 ns (± 25782) |
1.01 |
mul-two-forwards/create |
1990500 ns (± 96597) |
2035000 ns (± 14973) |
0.98 |
mul-two-forwards/rewrite |
3268500 ns (± 59865) |
3072000 ns (± 13686) |
1.06 |
add-zero-reuse-first/create |
1606500 ns (± 57375) |
1656000 ns (± 22961) |
0.97 |
add-zero-reuse-first/rewrite |
10500 ns (± 2772) |
12000 ns (± 1695) |
0.88 |
add-zero-lots-of-reuse-first/create |
1605000 ns (± 55788) |
1646000 ns (± 17889) |
0.98 |
add-zero-lots-of-reuse-first/rewrite |
840500 ns (± 65303) |
706000 ns (± 14318) |
1.19 |
This comment was automatically generated by workflow using github-action-benchmark.
Collaborator
Author
|
!radar |
Collaborator
|
Benchmark results for 86b5bd1 against 5a29f4b are in. There are significant results. @math-fehr Large changes (2✅)
Medium changes (1✅)
Small changes (1🟥)
|
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Jul 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Jul 18, 2026
tobiasgrosser
force-pushed
the
math-fehr/last-modules
branch
from
July 18, 2026 04:18
86b5bd1 to
169727f
Compare
These were the last files that were not modules.
tobiasgrosser
force-pushed
the
math-fehr/last-modules
branch
from
July 18, 2026 04:22
169727f to
0778734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were the last files that were not modules.