Part 1: Remove nonfunctional retirement API methods and references#38414
Part 1: Remove nonfunctional retirement API methods and references#38414VAIBHAVPANT07 wants to merge 3 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @VAIBHAVPANT07! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @VAIBHAVPANT07, and thank you for this contribution! You should be receiving a document via Docusign to send back to us so we can get your CLA check to turn green. If you don't see it, please check any spam / junk folders. |
|
Hi @mphilbrick211 , thanks for the heads up! I've already signed the CLA via DocuSign. Please let me know if there's anything else needed on my end. |
|
@VAIBHAVPANT07 Your branch was behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run. You should pull the changes into your local branch. |
213590b to
08e5fef
Compare
08e5fef to
c4c7fe9
Compare
|
Hi @e0d , I've re-pushed with conventional commit messages fixed. I've also already signed the CLA via DocuSign. Could you please verify the CLA status and approve the workflows to re-run the checks? |
Summary
Part 1 of #37720 — Removes nonfunctional retirement API methods from
edx_api.pyand cleans up their direct references in the user retirement pipeline.
This is an incremental PR. Doc updates and any remaining references
will be addressed in Part 2 and Part 3.
What Was Removed
Methods deleted from
edx_api.py:EcommerceApi.retire_learnerEcommerceApi.get_tracking_keyCredentialsApi.retire_learnerReferences cleaned up in retirement pipeline:
retire_one_user.pyTests & Docs:
Validation
Result: 33 passed, 0 failed
Risk Assessment
Low. All changes are contained within this repository.
External configs that reference these method names at runtime
may require separate updates outside this repo, as noted in the issue.
Status
Partially addresses #37720
driver_setup.rstdocumentation