Repository navigation
Point the unit tests badge at build-and-test-workflow.yml - #1251
Merged
Merged
Conversation
No workflow is named "Unit tests workflow" any more, so the name based badge and its actions?query link are broken. Unit tests run in build-and-test-workflow.yml (yarn run test:jest). Signed-off-by: Gaurav K Ohri <gohri81@gmail.com>
gohri81-tech
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis,
kaituo,
ohltyler,
owaiskazi19 and
sean-zheng-amazon
as code owners
September 23, 2026 05:40
PR Reviewer Guide 🔍(Review updated until commit 3cdc808)Here are some key observations to aid the review process:
|
Signed-off-by: Gaurav K Ohri <gohri81@gmail.com>
|
Persistent review updated to latest commit 3cdc808 |
kaituo
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Unit tests" badge at the top of the README uses the old name-based form,
workflows/Unit%20tests%20workflow/badge.svg, and links toactions?query=workflow:"Unit tests workflow". No workflow in.github/workflowshas that name any more, so the badge is broken. The unit tests now run inbuild-and-test-workflow.yml("Build and test workflow"), whose jobs are named "Build the plugin and run unit tests" and runyarn run test:jest.This switches the badge and its link to the file-based form for that workflow, the same form the Integration tests badge next to it already uses. The badge label is unchanged.
A CHANGELOG entry carrying this PR number follows in a second commit.
One thing I noticed but did not touch: the Security section here and SECURITY.md still send reports to AWS/Amazon Security, while some other opensearch-project repos have moved to security@opensearch.org. That is your call, so I left it alone.
Issues Resolved
None filed.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.