Repository navigation
Conversation
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 8, 2026 06:33 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 8, 2026 06:33 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 8, 2026 06:33 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 8, 2026 06:33 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
PR Reviewer Guide 🔍(Review updated until commit a50a3e6)Here are some key observations to aid the review process:
|
Ifetilayo
marked this pull request as ready for review
October 9, 2026 20:52
Ifetilayo
requested review from
HenryL27,
Zhangxunmt,
akolarkunnu,
austintlee,
b4sjoo,
jiapingzeng,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
rithinpullela,
sam-herman,
ylwu-amzn and
zane-neo
as code owners
October 9, 2026 20:52
Ifetilayo
changed the title
2 of 5 tasks
…agentic search template Transport failures from client.update/get/delete arrive wrapped in RemoteTransportException, so the instanceof checks in AgenticSearchTemplateService never matched and a metadata-only update of a missing id leaked the raw document_missing_exception. Unwrap the cause before checking. Part of opensearch-project#5035 (3.7). Signed-off-by: Ifetilayo Adebambo <adebambb@amazon.com>
Ifetilayo
force-pushed
the
fix/5035-pr1-update-404
branch
from
October 12, 2026 22:04
3f8d5fa to
27f2e71
Compare
|
Persistent review updated to latest commit 27f2e71 |
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 22:06 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 22:06 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 22:06 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 22:06 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
|
Persistent review updated to latest commit a50a3e6 |
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 23:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 23:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 23:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Ifetilayo
requested a deployment
to
ml-commons-cicd-env-require-approval
October 12, 2026 23:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Collaborator
|
LGTM |
b4sjoo
approved these changes
Oct 15, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes 3.7 from #5035. A metadata-only
PUT /_plugins/_ml/agentic_search_templates/{id}for a missing id returned the rawdocument_missing_exception(index name, shard and uuid included) instead ofAgentic search template not found: <id>. The status was already 404; only the body was wrong.Cause: transport failures arrive wrapped in
RemoteTransportException, so theinstanceof DocumentMissingExceptioncheck inwriteTemplatePatchnever matched. Everyinstanceofcheck inAgenticSearchTemplateService(update, get, list, delete, mapping fetch, register conflict) now unwraps the cause first withExceptionsHelper.unwrapCause. Other exceptions are forwarded unchanged.Tests: the existing test passed a raw
DocumentMissingExceptionand so hid the bug. New cases pass the wrapped form for update, get, delete and register conflict, and one checks that unrelated exceptions pass through as-is.One of four PRs for #5035. Merge order: #5120 (3.7) → #5121 (3.2–3.5) → #5122 (3.1) → #5123 (3.6).
Related Issues
Part of #5035. Introduced in 3.9 by #4945; the touched files are identical on
mainand3.9, so please addbackport 3.9.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.