HYPERFLEET-1101 - chore: add LeakTK secret scanning and update hooks#180
HYPERFLEET-1101 - chore: add LeakTK secret scanning and update hooks#180rafabene wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Supply chain surface (CWE-829, CWE-494): Three external hook repositories now execute arbitrary code in developer environments and CI pipelines.
Missing
Hook enumeration in docs (AGENTS.md): Listing active checks in developer documentation provides a discoverable bypass map. Adversaries committing to this repository now know exactly which controls exist and can route payloads around them. 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.pre-commit-config.yaml:
- Around line 4-8: The LeakTK pre-commit hook in the .pre-commit-config.yaml
file is pinned to a version tag (v0.3.3) instead of a commit SHA, which violates
supply-chain security best practices. Replace the rev field value with the full
commit SHA of the LeakTK repository. Additionally, there is a version mismatch:
the architecture repo documents LeakTK as v0.3.2 but this configuration pins
v0.3.3. Either revert to v0.3.2 to align with documented standards, or add a
comment documenting the reason for the version upgrade.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 74e19d9a-ea1a-4549-adb0-1c92f1ffb45a
📒 Files selected for processing (2)
.pre-commit-config.yamlAGENTS.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift-hyperfleet/architecture(manual)openshift-hyperfleet/hyperfleet-api(manual)openshift-hyperfleet/hyperfleet-sentinel(manual)openshift-hyperfleet/hyperfleet-adapter(manual)openshift-hyperfleet/hyperfleet-broker(manual)
1269a84 to
198c794
Compare
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Risk Score: 0 —
|
| Signal | Detail | Points |
|---|---|---|
| PR size | 35 lines | +0 |
| Sensitive paths | none | +0 |
Computed by hyperfleet-risk-scorer
198c794 to
ec70a87
Compare
|
/retest |
|
/retest ci/prow/lint |
|
@rafabene: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- Add LeakTK v0.3.3 for secret scanning (open-source, no VPN required) - Update hyperfleet-hooks from v0.1.0 to v0.1.1 - Add pre-commit-hooks v6.0.0 for file hygiene (trailing whitespace, EOF, large files) - Update AGENTS.md with complete hook list
ec70a87 to
1e6ea05
Compare
Summary
Adds LeakTK secret scanning and updates the pre-commit configuration:
AGENTS.mdupdated with complete hook listAfter merging
Team members should run
make install-hooksto install the new hooks. First commit after installation takes 3-5 minutes while LeakTK compiles (one-time).Ref: https://redhat.atlassian.net/browse/HYPERFLEET-1101