Fix typos and remove literal quotes in error messages

[sebrandon1]

Summary

• Fix spelling errors in error strings: "occurered" → "occurred", "acces" → "access" (×3), "entires" → "entries"
• Remove unnecessary escaped literal quotes from noRefFileWasPassed and refFileNotExistsError error constants that were appearing in user-facing output
• Update 4 golden test files to match corrected strings

Jira: https://redhat.atlassian.net/browse/CNF-23706

Summary by CodeRabbit

• Bug Fixes
  • Corrected spelling and punctuation in comparison error messages, including “entries” and “access.”
  • Improved reference-configuration error formatting by removing unnecessary quotation marks.
  • Clarified diff and inline-diff error messages while preserving non-error handling for missing cluster-side values.
• Tests
  • Updated expected outputs to reflect the corrected wording and formatting.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Compare error messages now use corrected quoting and spelling. Matching golden files reflect the updated output. Cluster-side missing inline-diff values remain non-error.

Changes

Compare error messages

Layer / File(s)	Summary
Compare error message corrections pkg/compare/compare.go	Reference configuration errors no longer include embedded quotes. Override, diff, and inline-diff error messages use corrected spelling.
Golden output synchronization pkg/compare/testdata/NoInput/localerr.golden, pkg/compare/testdata/ReferenceConfigFileDoesntExist/localerr.golden, pkg/compare/testdata/ReferenceV2PerFieldMatcherValidation/localpathNotItTemplateerr.golden, pkg/compare/testdata/UserOverride/localfailOutputerr.golden	Golden outputs now match the corrected error formatting and spelling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: natifridman, zzztx

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the typo corrections and removal of literal quotes from user-facing error messages.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only error strings and golden files. No Ginkgo test declarations or test-title additions are present.
Test Structure And Quality	✅ Passed	PASS: The commit changes only error strings and four golden fixtures. It adds no Ginkgo tests, cluster resources, waits, or assertion code to review.
Microshift Test Compatibility	✅ Passed	The PR changes only compare.go and four golden files; no Ginkgo tests, unavailable API references, namespaces, or MicroShift-sensitive assumptions were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes one production Go file and four golden files only; it adds no Ginkgo e2e tests or multi-node/HA assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only error strings in pkg/compare/compare.go and four golden files; it adds no manifests, controllers, replicas, affinities, topology constraints, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The PR changes only error strings and golden files; it adds no process-level stdout writes or logging setup changes, and vendored klog defaults to stderr.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes one Go source file and four golden files; it adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The commit changes only error strings and golden files; it adds no weak crypto, custom crypto, secret comparisons, or token handling. Existing hashing uses SHA-256.
Container-Privileges	✅ Passed	The diff changes only Go error strings and golden text files; no container/Kubernetes manifest or listed privilege setting appears in the changed files.
No-Sensitive-Data-In-Logs	✅ Passed	The commit only changes wording in errors and golden files; no passwords, tokens, keys, PII, hostnames, or new logging statements were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adhil0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/compare/compare.go`:
- Around line 1070-1075: The inline-diff preprocessing in compare.go is treating
any false found state from NestedString as a missing field before checking the
returned error, which can mask malformed cluster data. Update the logic around
clusterValue, exist, and err so the error from NestedString is handled first and
reported with the existing fmt.Errorf path in the inline-diff preprocessing
block, and only continue when the field is truly absent with no error.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 14e0a7d4-53c5-4e75-9fd6-b1e3330053ee

📥 Commits

Reviewing files that changed from the base of the PR and between c6f72ee and c051d1b.

📒 Files selected for processing (5)

• pkg/compare/compare.go
• pkg/compare/testdata/NoInput/localerr.golden
• pkg/compare/testdata/ReferenceConfigFileDoesntExist/localerr.golden
• pkg/compare/testdata/ReferenceV2PerFieldMatcherValidation/localpathNotItTemplateerr.golden
• pkg/compare/testdata/UserOverride/localfailOutputerr.golden

✅ Files skipped from review due to trivial changes (4)

• pkg/compare/testdata/NoInput/localerr.golden
• pkg/compare/testdata/ReferenceConfigFileDoesntExist/localerr.golden
• pkg/compare/testdata/ReferenceV2PerFieldMatcherValidation/localpathNotItTemplateerr.golden
• pkg/compare/testdata/UserOverride/localfailOutputerr.golden

[openshift-ci]

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.