Skip to content

OCPBUGS-103583: Fix CVE-2026-33814: Update golang.org/x/net - #294

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
lack:fix-cve-2026-33814-release-4.19
Aug 31, 2026
Merged

OCPBUGS-103583: Fix CVE-2026-33814: Update golang.org/x/net#294
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
lack:fix-cve-2026-33814-release-4.19

Conversation

@lack

@lack lack commented Aug 26, 2026

Copy link
Copy Markdown
Member

Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:

  • Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
  • Update vendor modules
  • hack: use go tool directive for golangci-lint and track vendor files
  • Update report-creator golden files to match new go version outputs

@openshift-ci-robot

Copy link
Copy Markdown

@lack: No Jira issue with key CVE-2026 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:

  • Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
  • Update vendor modules
  • hack: use go tool directive for golangci-lint and track vendor files
  • Update report-creator golden files to match new go version outputs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9e3b4888-53e9-4199-8c8f-9f481de2ea71

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from adhil0 and natifridman August 26, 2026 20:39
@lack lack changed the title Fix CVE-2026-33814: Update golang.org/x/net OCPBUGS-103583: Fix CVE-2026-33814: Update golang.org/x/net Aug 26, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@lack: This pull request references Jira Issue OCPBUGS-103583, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-103583 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:

  • Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
  • Update vendor modules
  • hack: use go tool directive for golangci-lint and track vendor files
  • Update report-creator golden files to match new go version outputs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lack

lack commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

/approve

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2026
@lack

lack commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

/retest

@lack
lack force-pushed the fix-cve-2026-33814-release-4.19 branch 2 times, most recently from 3003d1c to e3259b7 Compare August 27, 2026 15:25
@pixelsoccupied

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed
SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:
- Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
- Update vendor modules
- hack: use go tool directive for golangci-lint and track vendor files
- Update report-creator golden files to match new go version outputs
@lack
lack force-pushed the fix-cve-2026-33814-release-4.19 branch from e3259b7 to 6d2cb16 Compare August 27, 2026 19:25
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

@lack: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lack

lack commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 31, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@lack: This pull request references Jira Issue OCPBUGS-103583, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-103786 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-103786 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pixelsoccupied

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 3a66ac2 into openshift:release-4.19 Aug 31, 2026
9 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@lack: Jira Issue OCPBUGS-103583: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-103583 has been moved to the MODIFIED state.

Details

In response to this:

Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:

  • Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
  • Update vendor modules
  • hack: use go tool directive for golangci-lint and track vendor files
  • Update report-creator golden files to match new go version outputs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants